Diya fix(finalDay): Set Final Day to format by PST#4532
Diya fix(finalDay): Set Final Day to format by PST#4532DiyaWadhwani wants to merge 1 commit intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Diya,
I have tried to test your PR but was unable to do so because of below issue. Do let me know if any of these steps do not sound correct to you.
Scenario 1: I have logged in with my owner account in one tab and my volunteer account in the other. Using owner account i try to give the set final day permission to my volunteer account, it does give toast notification that permissions have been changed but i do not see the set final day at my volunteer account, even after i logout and log back in for the permissions to reflect.



Scenario 2: Since the above scenario did not work, i logged into an admin account which already had the set final day permission, when selecting, the calendar showed me the option to only select the next day as you can see in below images, and when i do click on save the page crashes with below error. Same thing also happens in my admin account when i load the user management page to set final day via the button.





Note: i did not test this in the owner account as i could not risk losing the account in case anything crashes
debadyuti23
left a comment
There was a problem hiding this comment.
Hi @DiyaWadhwani I have reviewed your changes with the instructions you mentioned. I logged in as admin and tried to set final day for my volunteer account however it says I dont have permission and the page crashes out afterwards. See the video for the details
PR_4532.mp4
|
@Anusha-Gali @VijayAnirudh @debadyuti23 |




Description
This PR fixes the final day issue.
Related PRS (if any):
None
Main changes explained:
How to test:
npm installand...to run this PR locally