Skip to content

Diya fix(finalDay): Set Final Day to format by PST#4532

Closed
DiyaWadhwani wants to merge 1 commit intodevelopmentfrom
Diya_Fix_UserFinalDay
Closed

Diya fix(finalDay): Set Final Day to format by PST#4532
DiyaWadhwani wants to merge 1 commit intodevelopmentfrom
Diya_Fix_UserFinalDay

Conversation

@DiyaWadhwani
Copy link
Copy Markdown
Contributor

Description

This PR fixes the final day issue.

Related PRS (if any):

None

Main changes explained:

  • Created a new function to format the date in PST, considering the end of the day
  • Using this function to set and display the final day in PST
  • Passing PST end of day to the backend to store in DB, and then using the same formatter to display it on the UI

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. User Profile > Set Final Day > Verify by reloading or switching tabs that the day stays the same
  6. Head to User Management and verify that the end date has been updated.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit e0d5533
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/693783498ac9d6000731c50d
😎 Deploy Preview https://deploy-preview-4532--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 9, 2025

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Diya,

I have tried to test your PR but was unable to do so because of below issue. Do let me know if any of these steps do not sound correct to you.
Scenario 1: I have logged in with my owner account in one tab and my volunteer account in the other. Using owner account i try to give the set final day permission to my volunteer account, it does give toast notification that permissions have been changed but i do not see the set final day at my volunteer account, even after i logout and log back in for the permissions to reflect.
Screenshot 2025-12-08 at 11 33 23 PM
Screenshot 2025-12-08 at 11 33 26 PM
Screenshot 2025-12-08 at 11 33 31 PM
Scenario 2: Since the above scenario did not work, i logged into an admin account which already had the set final day permission, when selecting, the calendar showed me the option to only select the next day as you can see in below images, and when i do click on save the page crashes with below error. Same thing also happens in my admin account when i load the user management page to set final day via the button.
Screenshot 2025-12-08 at 11 34 31 PM
Screenshot 2025-12-08 at 11 34 47 PM
Screenshot 2025-12-08 at 11 34 54 PM
Screenshot 2025-12-08 at 11 35 52 PM
Screenshot 2025-12-08 at 11 36 36 PM

Note: i did not test this in the owner account as i could not risk losing the account in case anything crashes

Copy link
Copy Markdown

@debadyuti23 debadyuti23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DiyaWadhwani I have reviewed your changes with the instructions you mentioned. I logged in as admin and tried to set final day for my volunteer account however it says I dont have permission and the page crashes out afterwards. See the video for the details

PR_4532.mp4

Copy link
Copy Markdown

@VijayAnirudh VijayAnirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I followed the steps and right after setting final day as today, this happened:
image

@DiyaWadhwani
Copy link
Copy Markdown
Contributor Author

@Anusha-Gali @VijayAnirudh @debadyuti23
Please refer to new PR #4578 + #1961
Addressed above concerns in these new PRs too. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants