Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/actions/userManagement.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,7 @@ export const updateUserFinalDayStatusIsSet = (user, status, finalDayDate, isSet)
// Prepare patch data
const patchData = {
status,
endDate: finalDayDate
? moment.utc(finalDayDate).format('YYYY-MM-DD')
: undefined,
endDate: finalDayDate ?? undefined,
isSet,
};

Expand Down
5 changes: 4 additions & 1 deletion src/components/UserManagement/SetUpFinalDayButton.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { boxStyle } from '../../styles';
import SetUpFinalDayPopUp from './SetUpFinalDayPopUp';
import { SET_FINAL_DAY, CANCEL } from '../../languages/en/ui';
import { FinalDay } from '../../utils/enums';
import { formatEndDatePST } from '../../utils/formatDate';

function SetUpFinalDayButton(props) {
const { darkMode, userProfile, onFinalDaySave } = props;
Expand Down Expand Up @@ -40,11 +41,13 @@ function SetUpFinalDayButton(props) {
};

const handleSaveFinalDay = async (finalDayDate) => {

const finalInstant = formatEndDatePST(finalDayDate);
try {
await updateUserFinalDayStatusIsSet(
userProfile,
'Active',
finalDayDate,
finalInstant,
FinalDay.FinalDay,
)(dispatch);

Expand Down
10 changes: 5 additions & 5 deletions src/components/UserManagement/UserTableData.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { UserStatus } from '../../utils/enums';
import ActiveCell from './ActiveCell';
import TimeDifference from './TimeDifference';
import { boxStyle } from '../../styles';
import { formatDateLocal, formatDateUtcYYYYMMDD } from '../../utils/formatDate';
import { formatDateLocal, formatDateUtcYYYYMMDD, formatEndDatePST } from '../../utils/formatDate';
import hasPermission, {cantUpdateDevAdminDetails } from '../../utils/permissions';
import SetUpFinalDayButton from './SetUpFinalDayButton';

Expand Down Expand Up @@ -42,7 +42,7 @@ const UserTableDataComponent = (props) => {
email: props.user.email,
weeklycommittedHours: props.user.weeklycommittedHours,
startDate: formatDateUtcYYYYMMDD(props.user.startDate) || '',
endDate: formatDateUtcYYYYMMDD(props.user.endDate) || '',
endDate: formatEndDatePST(props.user.endDate) || '',
});
const dispatch = useDispatch();
const history = useHistory();
Expand Down Expand Up @@ -98,7 +98,7 @@ const UserTableDataComponent = (props) => {
email: props.user.email,
weeklycommittedHours: props.user.weeklycommittedHours,
startDate: formatDateUtcYYYYMMDD(props.user.startDate),
endDate: formatDateUtcYYYYMMDD(props.user.endDate),
endDate: formatEndDatePST(props.user.endDate),
});
}, [props.user]);

Expand Down Expand Up @@ -524,13 +524,13 @@ const UserTableDataComponent = (props) => {
<td className="email_cell">
{editUser?.endDate ? (
<div>
{props.user.endDate ? formatDateLocal(props.user.endDate) : 'N/A'}
{props.user.endDate ? formatEndDatePST(props.user.endDate) : 'N/A'}
<FontAwesomeIcon
className="copy_icon"
icon={faCopy}
onClick={() => {
navigator.clipboard.writeText(
props.user.endDate ? formatDateLocal(formData.endDate) : 'N/A',
props.user.endDate ? formatEndDatePST(formData.endDate) : 'N/A',
);
toast.success('End Date Copied!');
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import SetUpFinalDayButton from '~/components/UserManagement/SetUpFinalDayButton
import './BasicInformationTab.css';
import { boxStyle, boxStyleDark } from '~/styles';
import EditableInfoModal from '~/components/UserProfile/EditableModal/EditableInfoModal';
import { formatDateLocal } from '~/utils/formatDate';
import { formatEndDatePST, formatDateLocal } from '~/utils/formatDate';
import { ENDPOINTS } from '~/utils/URL';
import axios from 'axios';
import { isString } from 'lodash';
Expand Down Expand Up @@ -911,6 +911,10 @@ const BasicInformationTab = props => {
</>
);

const handleFinalDayChange = (updatedUser) => {
setUserProfile(updatedUser);
};

const endDateComponent = (
<>
<Col md={desktopDisplay ? '5' : ''}>
Expand All @@ -922,7 +926,7 @@ const BasicInformationTab = props => {
<div style={{ display: 'flex', alignItems: 'center', justifyContent: 'space-between' }}>
<Label className={darkMode ? 'text-light' : ''} style={{ margin: '0' }}>
{userProfile.endDate
? formatDateLocal(userProfile.endDate)
? formatEndDatePST(userProfile.endDate)
: 'N/A'}
</Label>
{canEdit && canEditEndDate && (
Expand All @@ -932,6 +936,7 @@ const BasicInformationTab = props => {
isBigBtn={true}
userProfile={userProfile}
darkMode={darkMode}
onFinalDaySave={handleFinalDayChange}
/>
)}
</div>
Expand Down
7 changes: 7 additions & 0 deletions src/utils/formatDate.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ export const formatDateUtcYYYYMMDD = (val) => {
return moment(val, moment.ISO_8601, true).utc().format('YYYY-MM-DD');
};

export const formatEndDatePST = (selectedDateString) => {
return moment
.tz(selectedDateString, LA_TIME_ZONE) // interpret date as LA/PST
.endOf('day') // set 23:59:59.999
.toDate(); // convert to UTC ISO for DB
}

/**
*
* @param {*} date UTC timestamp string
Expand Down
Loading