Skip to content

Shashank madan pr grading frontend#4533

Merged
one-community merged 9 commits intodevelopmentfrom
shashank-madan-pr-grading-frontend
Jan 26, 2026
Merged

Shashank madan pr grading frontend#4533
one-community merged 9 commits intodevelopmentfrom
shashank-madan-pr-grading-frontend

Conversation

@shashank-madan
Copy link
Copy Markdown
Contributor

@shashank-madan shashank-madan commented Dec 9, 2025

Description

image

Related PRS (if any):

This frontend PR is related to the #1947 backend PR.

Main changes explained:

  • Added Pages for PR Grading dashboard
  • Implemented logic to allow only valid pr numbers as inputs
  • Added dark mode styling to all pages in pr grading dashboard

How to test:

  1. check into current branch
  2. do yarn install and yarn vite to run this PR locally
  3. Clear site data/cache
  4. log as owner user
  5. go to http://localhost:5173/pr-grading-dashboard
  6. Add a new reviewed PR to one of the reviewers
  7. Add a new reviewer
  8. Click Save
  9. Verify that you get toast messages indicating success at the steps.
  10. Refresh the page and verify that your changes have persisted
  11. Check dark mode as well

Screenshots or videos of changes:

PR-grading-dashboard.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 0c8281f
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6976cf03271d060008330177
😎 Deploy Preview https://deploy-preview-4533--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shashank-madan shashank-madan added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 9, 2025
Anusha-Gali
Anusha-Gali previously approved these changes Dec 12, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

I have reviewed your PR locally and all the functionality perform as per requirement in both the modes, i do have one suggestion, a toast notification after deleting a PR.
Screenshot 2025-12-12 at 12 30 48 AM
Screenshot 2025-12-12 at 12 32 07 AM
Screenshot 2025-12-12 at 12 32 30 AM
Screenshot 2025-12-12 at 12 34 24 AM
Screenshot 2025-12-12 at 12 34 27 AM
Screenshot 2025-12-12 at 12 34 37 AM
Screenshot 2025-12-12 at 12 34 44 AM
Screenshot 2025-12-12 at 12 35 26 AM
Screenshot 2025-12-12 at 12 35 30 AM
Screenshot 2025-12-12 at 12 35 40 AM
Screenshot 2025-12-12 at 12 36 50 AM

@sonarqubecloud
Copy link
Copy Markdown

Anusha-Gali
Anusha-Gali previously approved these changes Jan 21, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

Reviewing your PR again since Jae asked and you have made few changes. Thanks for adding the suggestion i mentioned. Would like to point out only one issue: As you can see below in dark mode, we cannot see the color of the Valid or Invalid Format similar to that in light mode. (The second and third image respectively)

I am approving the PR since all functionalities work but someone could point it out in merge review.
Screenshot 2026-01-21 at 6 22 32 PM
Screenshot 2026-01-21 at 6 23 00 PM
Screenshot 2026-01-21 at 6 23 39 PM
Screenshot 2026-01-21 at 6 23 52 PM
Screenshot 2026-01-21 at 6 23 55 PM
Screenshot 2026-01-21 at 6 24 17 PM
Screenshot 2026-01-21 at 6 24 39 PM
Screenshot 2026-01-21 at 6 24 43 PM

@beblicarl
Copy link
Copy Markdown
Contributor

This feature works as intended and the code is great

https://www.loom.com/share/7ddcfa86652e4f389e4c13869f5facc2

@beblicarl beblicarl self-requested a review January 23, 2026 14:31
beblicarl
beblicarl previously approved these changes Jan 23, 2026
@shashank-madan shashank-madan dismissed stale reviews from beblicarl and Anusha-Gali via 97f3f65 January 24, 2026 04:58
Anusha-Gali
Anusha-Gali previously approved these changes Jan 24, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

Thanks for updating the code. The issue is fixed and all the other functionalities work as expected.
Screenshot 2026-01-24 at 4 39 10 PM
Screenshot 2026-01-24 at 4 39 39 PM
Screenshot 2026-01-24 at 4 39 54 PM
Screenshot 2026-01-24 at 4 40 00 PM

@sonarqubecloud
Copy link
Copy Markdown

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 33ef443 into development Jan 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants