Skip to content

Chirag tool status filter and sort dropdown addition#4535

Merged
one-community merged 8 commits intodevelopmentfrom
chirag-tool-status-filter-and-sort-dropdown-addition
Dec 19, 2025
Merged

Chirag tool status filter and sort dropdown addition#4535
one-community merged 8 commits intodevelopmentfrom
chirag-tool-status-filter-and-sort-dropdown-addition

Conversation

@ChiragBellara
Copy link
Copy Markdown
Contributor

Description

PNG image

Related PRS (if any):

This change is NOT related to any other PRs.

Main changes explained:

  • Created new filters for Tool Status and Conditions
  • Implemented sorting based on Condition and Using columns
  • Added state persistence on refresh for the filter conditions.
  • Updated logic to support combination filtering on client side to reduce API overload.

How to test:

  1. check into current branch
  2. do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. navigate to /bmdashboard/tools
  6. verify that the filtering and sorting works
  7. check that the filter conditions are persistent on screen refresh.

Screenshots or videos of changes:

Tool.Filtering.and.Sorting.demo.mov

Note:

  • Note that the Condition filter includes all the distinct values present in the condition column of the table. So, it can include options that are different from New, Worn, Damaged, Good. This is done to ensure that the user does not see any filter conditions that are not actually present in the table itself.
  • Also, the sorting for the "Using" column is done such that when the column is sorted in Ascending (indicated by a filled upward arrow head (^)) order we see the tools which are have "Using" set to False (indicated by ⤬ marks) first and in Descending order we see the tools which are have "Using" set to True (indicated by ✓ marks) first.
  • Lastly, the state persistence is created such that the filters will retain their values as long as the session is active i.e. if you close the browser window or tab the filters should reset.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit eb69592
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6940778839610f0008d5ad49
😎 Deploy Preview https://deploy-preview-4535--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 12, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chirag,

I have reviewed your PR locally and all the requirements perform as per the functionality mentioned, i have noticed that the table headers are not in correspondence to the dark mode and also i have gotten this below issue in console which got fixed after commenting the stated line. Please check with Jae before merge.
Screenshot 2025-12-11 at 11 43 43 PM
Screenshot 2025-12-11 at 11 48 58 PM
Screenshot 2025-12-11 at 11 48 18 PM
Screenshot 2025-12-11 at 11 49 11 PM
Screenshot 2025-12-11 at 11 49 16 PM
Screenshot 2025-12-11 at 11 47 49 PM
Screenshot 2025-12-11 at 11 47 54 PM
Screenshot 2025-12-11 at 11 48 03 PM
Screenshot 2025-12-11 at 11 48 12 PM

Note: Do let me know and i would approve the PR as the main functionality works

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chirag,

The issues of dark mode and the console are fixed.
Screenshot 2025-12-16 at 3 20 28 PM
Screenshot 2025-12-16 at 3 20 56 PM
Screenshot 2025-12-16 at 3 21 03 PM
Screenshot 2025-12-16 at 3 21 11 PM
Screenshot 2025-12-16 at 3 21 22 PM

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit f185c5a into development Dec 19, 2025
10 checks passed
@ChiragBellara ChiragBellara deleted the chirag-tool-status-filter-and-sort-dropdown-addition branch February 17, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants