Skip to content

Shashank madan intermediate tasks dark mode#4560

Merged
one-community merged 3 commits intodevelopmentfrom
shashank-madan-intermediate-tasks-dark-mode
Dec 22, 2025
Merged

Shashank madan intermediate tasks dark mode#4560
one-community merged 3 commits intodevelopmentfrom
shashank-madan-intermediate-tasks-dark-mode

Conversation

@shashank-madan
Copy link
Copy Markdown
Contributor

Description

Steps to test this are same as pr #4454

Only additionally test dark mode screens

Screenshots of changes:
image
image
image

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 15, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 5803622
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/694238f232982b00074f0352
😎 Deploy Preview https://deploy-preview-4560--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 16, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

I have followed the same steps as mentioned in the PR you have attached, do note my backend is on development branch and frontend on your PR branch. The dark mode does not seem to be working as shown in your images.
Screenshot 2025-12-16 at 10 59 47 PM
Screenshot 2025-12-16 at 10 59 55 PM
Screenshot 2025-12-16 at 11 00 19 PM
Screenshot 2025-12-16 at 11 01 39 PM
Screenshot 2025-12-16 at 11 02 13 PM
Screenshot 2025-12-16 at 11 02 28 PM

@sonarqubecloud
Copy link
Copy Markdown

@shashank-madan
Copy link
Copy Markdown
Contributor Author

Hi Shashank,

I have followed the same steps as mentioned in the PR you have attached, do note my backend is on development branch and frontend on your PR branch. The dark mode does not seem to be working as shown in your images. Screenshot 2025-12-16 at 10 59 47 PM Screenshot 2025-12-16 at 10 59 55 PM Screenshot 2025-12-16 at 11 00 19 PM Screenshot 2025-12-16 at 11 01 39 PM Screenshot 2025-12-16 at 11 02 13 PM Screenshot 2025-12-16 at 11 02 28 PM

Please try again now. Based on your screenshots I can see that some modals/files are correctly working with dark mode and some are not. I have modified css selectors for dark mode in the module.css files to align with the patterns on the modals that worked correctly according to your screenshots. Issues like this come up due to some differences in the build process. These changes should fix the styling.

@VijayAnirudh
Copy link
Copy Markdown

Hi Shashank,
I followed the steps from 4494 and tested, and everything looks good on my end. Since I don’t have any tasks assigned, I wasn’t able to check how the task cards appear in dark mode. Also, I noticed there isn’t a dedicated tasks page available for me to review.

image image image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shashank,

I have re-reviewed your PR and it supports dark mode now.
Screenshot 2025-12-19 at 9 27 11 PM
Screenshot 2025-12-19 at 9 27 17 PM
Screenshot 2025-12-19 at 9 27 23 PM
Screenshot 2025-12-19 at 9 27 26 PM
Screenshot 2025-12-19 at 9 27 50 PM

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit d7cb4f0 into development Dec 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants