Sharadha taking over for Manvitha phase 3 - feedback form#4586
Sharadha taking over for Manvitha phase 3 - feedback form#4586myeeli wants to merge 17 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
VijayAnirudh
left a comment
VijayAnirudh
left a comment
There was a problem hiding this comment.
2 test cases failed!
Skipped test cases; changes are as expected. I can submit feedback and rate with stars.
one-community
added
the
High Priority - Please Review First
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Manvitha,
Feedback is working as expected. Well done on this implementation (I know it's out of scope but dark mode is not functional at all)
Vikas-8055
left a comment
Vikas-8055
left a comment
There was a problem hiding this comment.
hi manvitha i have reviewed and tested your PR everything works as expected
Shravan-neelamsetty
left a comment
Shravan-neelamsetty
left a comment
There was a problem hiding this comment.
Hi Manvitha, I have tested this PR locally by checking out the Manvitha-Phase-3-Feedback-Form branch and navigating to /communityportal/ActivitiesPage. The feedback functionality works as expected - I clicked the "Give Feedback" button in the top right corner which opened the feedback modal displaying the title "Activity Feedback" with a 5-star rating system, a text area for feedback input, and a character counter showing usage out of 300 characters. I successfully selected 3 stars for the rating, entered feedback text, and clicked "Submit Feedback" which triggered a green success banner displaying "Feedback submitted!" at the top of the modal. The star rating interaction is smooth, the text area accepts input correctly, and the character counter updates in real-time. The modal UI is clean and user-friendly with proper spacing and a close button.
Ganesh112001
left a comment
Ganesh112001
left a comment
There was a problem hiding this comment.
I tested PR #4586 and verified that the Phase 3 Feedback Form works well with one critical issue. After checking out the Manvitha-Phase-3-Feedback-Form branch and navigating to /communityportal/ActivitiesPage, I clicked "Give Feedback" on an activity and the feedback modal opened correctly. In light mode, the modal displays a well-designed form with a 5-star rating system that provides clear visual feedback when clicking stars, an optional comment field with a 300-character limit and live character counter, and functional Cancel and Submit buttons. Rating validation works correctly by requiring a star selection before submission. However, when I enabled dark mode, the feedback modal has severe visibility issues—text, input fields, stars, and buttons are not visible or have poor contrast against the dark background, making the form unusable in dark mode. The modal needs proper dark mode styling to ensure all elements are visible and readable. In light mode, everything works perfectly including submission and cancel functionality with no console errors. Dark mode support must be added before merge.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Manvitha,
I have reviewed your PR locally and though it works as expected, the title is pretty lite in dark mode.
| const modalRef = useRef(null); | ||
| const errorRef = useRef(null); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Focus trap works though modal doesn't auto-focus on open.
SharadhaKasiviswanathan
changed the title
9 participants
Description
Related PRS (if any):
This frontend PR is related to the development backend PR.
…
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
1.mp4
Note:
Include the information the reviewers need to know.