Skip to content

Tom - Phase 3 – Add Validation Message When Past Date Is Selected in Activities List#4592

Open
tomkkl wants to merge 3 commits intodevelopmentfrom
tomkkl-validation-updated
Open

Tom - Phase 3 – Add Validation Message When Past Date Is Selected in Activities List#4592
tomkkl wants to merge 3 commits intodevelopmentfrom
tomkkl-validation-updated

Conversation

@tomkkl
Copy link
Copy Markdown

@tomkkl tomkkl commented Dec 20, 2025

Screenshot 2026-01-06 at 3 41 20 AM

Screenshots or videos of changes:

Screen.Recording.2025-11-15.at.9.38.04.PM.mov

Related PRs
N/A

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /communityportal/activities
  6. Select a date that is before the date of testing
  7. Selecting a date that is before the date of testing should display a validation message

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 20, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 38fc616
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69466402fe962300086e9341
😎 Deploy Preview https://deploy-preview-4592--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

@one-community one-community changed the title Tomkkl validation updated Tom - Validation updated Dec 22, 2025
@one-community one-community changed the title Tom - Validation updated Tom - Phase 3 – Add Validation Message When Past Date Is Selected in Activities List Dec 22, 2025
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 22, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom,

I have reviewed your PR locally and the page is not reflecting the page you have shown in the video and even the functionality of calendar is breaking. Have attached the video showcasing the issue.

4592.mp4

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom,

Few things I'd like to mention:

  1. Please utilise the proper format for the PR submission.
  2. Your implementation is not working. --> Firstly, the webpage looks different to what is in your video. Secondly, the website crashes when a previous date is selected.

Please correct and let me know to re-review.

PR 4592 Screenshot PR 4592 Screenshot 3 PR 4592 Screenshotn2

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. do not review Do not review or look at code without full context and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants