Skip to content

Ajay: Fixed the dark theme in Weekly Report Summaries#4594

Closed
naiduajaykumar wants to merge 10 commits intodevelopmentfrom
Ajay_fixed_dark_mode_in_WeekelySummeryReport
Closed

Ajay: Fixed the dark theme in Weekly Report Summaries#4594
naiduajaykumar wants to merge 10 commits intodevelopmentfrom
Ajay_fixed_dark_mode_in_WeekelySummeryReport

Conversation

@naiduajaykumar
Copy link
Copy Markdown
Contributor

@naiduajaykumar naiduajaykumar commented Dec 20, 2025

Description

Fixed the dark theme for input fields and all components in Weekly Summaries Report Page.

Related PRS (if any):

Not related to any PR

How to test:

  1. check into current branch
  2. do yarn install and run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Reports → Weekly Summaries Report

Screenshots or videos of changes:

Recording.2025-12-20.131225.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 20, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 9051e2d
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/695b5b9055abca000885c0bd
😎 Deploy Preview https://deploy-preview-4594--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@naiduajaykumar naiduajaykumar changed the title fix(weekly-summaries): improve dark mode styling Ajay: Fixed the dark theme in Weekly Report Summaries Dec 21, 2025
Copy link
Copy Markdown
Contributor

@JuliaHa0902 JuliaHa0902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ajay,
I have reviewed the pull request. Overall the dark theme looks good, however there are a few missing spots that you haven't covered yet.
When hovering over the dropdown in Select Extra Member, the text cannot be seen
Screenshot 2025-12-20 233910
The modal Create New Filter and Update/Delete Filter hasn't been fixed yet. The button in the bottom of the modal blends in with the background.
Screenshot 2025-12-20 233938
Screenshot 2025-12-20 234032
Screenshot 2025-12-20 234051
The text: No data available for this tab cannot be seen
Screenshot 2025-12-20 234226

More importantly, the functionality of the mini filters breaks. You can see the video for more details.
https://github.com/user-attachments/assets/7993d116-f20e-425a-8292-4e2cd40268a7

Just minor details, but the color of the navbar is the same as the color of the background. Maybe can you change the background to a different color, so that we can see the separation please?
Screenshot 2025-12-20 234248

Copy link
Copy Markdown

@vivekchandrabs vivekchandrabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-12-26 at 4 20 34 PM

Dark mode theme is not working for this component

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 29, 2025
Copy link
Copy Markdown

@VijayAnirudh VijayAnirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

  1. Dark theme is fine!
  2. I can't see names or text when I hover over them!

Faced same issues as Julia. Please fix them.

image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ajay,

I have reviewed your PR locally and all the issues mention by Julia are still very much present. Please do fix them.
Screenshot 2025-12-31 at 8 03 42 PM
Screenshot 2025-12-31 at 8 03 47 PM
Screenshot 2025-12-31 at 8 03 57 PM
Screenshot 2025-12-31 at 8 04 07 PM
Screenshot 2025-12-31 at 8 04 18 PM
Screenshot 2025-12-31 at 8 04 37 PM
Screenshot 2025-12-31 at 8 04 58 PM
Screenshot 2025-12-31 at 8 05 01 PM
Screenshot 2025-12-31 at 8 05 17 PM
Screenshot 2025-12-31 at 8 05 24 PM
Screenshot 2025-12-31 at 8 05 26 PM

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ajay,

Good job with the overall implementation.

Couples fixes are the drop down menu in the image below and the "no data to show' text box.

PR 4594 Screenshot PR 4594 Screenshot 2

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 5, 2026

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ajay,

Thank you for fixing the issues. Good implementation.

Quick Question: the Extra members dropdown essentially freezes the page for a good 10-15s for me. Is this normal? I don't recall it doing this before the fix.

PR 4594 Screenshot PR 4594 Screenshot 2

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ajay,

Thanks for fixing the issues. I do have a question. The one's which are fixed do not follow the color code template for dark mode in respect to one community guidelines. Do checkbase on this.
Screenshot 2026-01-07 at 10 46 56 PM
Screenshot 2026-01-07 at 10 50 21 PM
Screenshot 2026-01-07 at 10 50 35 PM

Copy link
Copy Markdown
Contributor

@JuliaHa0902 JuliaHa0902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ajay,
I have reviewed the PR again and I can see that the PR has fixed the dark theme of most component in Weekly Summaries Report page.
However, multiple functionalities was break due to this change.

  1. Mini-filter breaks
    When you choose a filter here, the page breaks
Screenshot 2026-01-08 225928 Screenshot 2026-01-08 225815
  1. Replace All team code breaks, also the error text cannot be seen in dark mode
Screenshot 2026-01-08 224026 Screenshot 2026-01-08 224316
  1. Replace team code of individual breaks
Screenshot 2026-01-08 224829

You can see more details in the video

Screen.Recording.2026-01-08.225451.mp4

@naiduajaykumar naiduajaykumar deleted the Ajay_fixed_dark_mode_in_WeekelySummeryReport branch January 22, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants