Skip to content

Swathi Fix for PR Review Team Analytics Dashboard - Main landing page gives a ‘Page not found’ Error.#4617

Merged
one-community merged 7 commits intodevelopmentfrom
Swathi_PR_Review_Team_Analytics_Dashboard
Feb 9, 2026
Merged

Swathi Fix for PR Review Team Analytics Dashboard - Main landing page gives a ‘Page not found’ Error.#4617
one-community merged 7 commits intodevelopmentfrom
Swathi_PR_Review_Team_Analytics_Dashboard

Conversation

@SwathiAngadi
Copy link
Copy Markdown
Contributor

Description

PR Review Team Analytics Dashboard - Main landing page gives a ‘Page not found’ Error. And other pages from PR Analytics board were showing 'Page not Found' Error.

Related PRS (if any):

NA

Main changes explained:

Added routes for the following pages

  1. PR Dashboard Overview
  2. PR Dashboard Promotion Eligibility
  3. PR Dashboard Top Reviewed PRs.
  4. PR Dashboard Details

How to test:

  1. check into current branch
  2. do npm install and 'npm run start' to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Able to hit below URLs without getting page not found error
  6. http://localhost:5173/pr-dashboard/overview
  7. http://localhost:5173/pr-dashboard/promotion-eligibility
  8. http://localhost:5173/pr-dashboard/top-reviewed-prs
Screenshot 2025-12-24 001026 Screenshot 2025-12-24 002438 Screenshot 2025-12-24 002525 Screenshot 2025-12-24 002549
  1. http://localhost:5173/pr-dashboard/details

Screenshots or videos of changes:

Note:

This PR is fix for 'Page not found' error. User should be able to land in respective pages.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 24, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit bf57c62
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6986614356e29700086d3aed
😎 Deploy Preview https://deploy-preview-4617--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Anusha-Gali
Anusha-Gali previously approved these changes Dec 26, 2025
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Swathi,

I have reviewed your PR locally and am able to access all the links mentioned. Though in your code i noticed a line "Unable to load the chart at this moment. Please try agian later". Please correct the spelling.
Screenshot 2025-12-25 at 9 14 39 PM
Screenshot 2025-12-25 at 9 14 56 PM
Screenshot 2025-12-25 at 9 15 14 PM
Screenshot 2025-12-25 at 9 16 20 PM

@sonarqubecloud
Copy link
Copy Markdown

@SwathiAngadi
Copy link
Copy Markdown
Contributor Author

Hi Anusha,

Thanks for the review. Accidentally I committed two files which were not part of this PR. I reverted those files.

sayali-2308
sayali-2308 previously approved these changes Jan 28, 2026
Copy link
Copy Markdown
Contributor

@sayali-2308 sayali-2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: Sayali Sable
Date: January 28, 2026
Branch Tested: Swathi_PR_Review_Team_Analytics_Dashboard

Testing Environment

  • Frontend: localhost:5173
  • Backend: Development branch (localhost:4500)
  • Node.js: v20.19.4

Problem Fixed
Before this PR, the following URLs showed "Page not found" error:

  • /pr-dashboard/overview
  • /pr-dashboard/promotion-eligibility
  • /pr-dashboard/top-reviewed-prs
  • /pr-dashboard/details

Solution Implemented
Added 4 new route definitions in src/routes.jsx file:

  • Line 903: Route for /pr-dashboard/overview (PRDashboardOverview component)
  • Lines 904-908: Route for /pr-dashboard/promotion-eligibility (PRDashboardPromotionEligibility component)
  • Lines 909-913: Route for /pr-dashboard/top-reviewed-prs (PRDashboardTopReviewedPRs component)
  • Line 914: Route for /pr-dashboard/details (PRDashboardDetails component)

Testing Results
All 4 Routes Working
Tested all 4 URLs and confirmed pages load successfully without "Page not found" error:

  1. Overview Page - Loads correctly, displays PR metrics (Open PRs, Stale PRs, Avg Review Time)
  2. Promotion Eligibility Page - Loads correctly, displays promotion review table
  3. Top Reviewed PRs Page - Loads correctly, displays sorted list of PRs by review activity
  4. Details Page - Loads correctly, displays PR details with description and CI/CD status

Multi-Role Testing
Tested with 3 different user roles as required:

  • Admin Account: All 4 routes load correctly
  • Manager Account: All 4 routes load correctly
  • Volunteer Account: All 4 routes load correctly

Code Changes Review

  • Only 12 lines added to routes.jsx (+12 lines, 0 deletions)
  • Clean implementation using ProtectedRoute wrapper
  • Consistent with existing route patterns in the file
  • All routes properly mapped to correct components

Findings

  • All 4 routes now accessible without "Page not found" error
  • Pages load across all user roles
  • No console errors
  • Routes follow existing code patterns
  • Minimal, focused change - only adds necessary routes
  • Note: "Failed to load Reviewers" message on promotion-eligibility page is a backend data issue, not related to this routing fix

Conclusion
PR successfully fixes the "Page not found" errors for all 4 PR Dashboard URLs. Routes are properly implemented and work across all user roles. This is a clean, focused fix that addresses the exact problem described.

Anusha-Gali
Anusha-Gali previously approved these changes Jan 29, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Swathi,

Thanks for the update. Re-reviewed your PR and i am able to access all the links.

Image Image Image Image

rohanrastogi311
rohanrastogi311 previously approved these changes Feb 1, 2026
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Swathi,

Good job with this fix, working well.

Image Image Image

Anusha-Gali
Anusha-Gali previously approved these changes Feb 4, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-reviewed the PR to approve it for merge.

rohanrastogi311
rohanrastogi311 previously approved these changes Feb 6, 2026
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Swathi,

Well done with this implementation. URLs work.

Image Image Image

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 6, 2026

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 4771833 into development Feb 9, 2026
10 checks passed
@SwathiAngadi SwathiAngadi deleted the Swathi_PR_Review_Team_Analytics_Dashboard branch February 9, 2026 20:55
pavanputti pushed a commit that referenced this pull request Feb 22, 2026
…m_Analytics_Dashboard

Swathi  Fix for PR Review Team Analytics Dashboard - Main landing page gives a ‘Page not found’ Error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants