Skip to content

Juhitha fix people report page UI#4635

Open
Juhitha-Reddy wants to merge 13 commits intodevelopmentfrom
Juhitha_fix_people_report_page_UI
Open

Juhitha fix people report page UI#4635
Juhitha-Reddy wants to merge 13 commits intodevelopmentfrom
Juhitha_fix_people_report_page_UI

Conversation

@Juhitha-Reddy
Copy link
Copy Markdown
Contributor

@Juhitha-Reddy Juhitha-Reddy commented Dec 27, 2025

Description

Fixed People Report page UI issues for mobile and narrow screens (375px and up). Improved table layout, column widths, and added comprehensive dark mode support for mobile card view and filter controls.

Fixes WBS: Fix PEOPLE REPORT PAGE UI issues for 375px and up (Juhitha Reddy Penumalli)

Related PRS (if any):

Reference to Previous PR #2005, PR #2650

Main changes explained:

  • Renamed PeopleTableDetails.cssPeopleTableDetails.module.css to comply with project CSS modules convention
  • Updated PeopleTableDetails.jsx to use CSS modules syntax for all className references
  • Widened Task column from 2.2fr to 3.5fr to display longer task names properly
  • Reduced other column widths (Priority, Status, Start Date, End Date from 1fr to 0.8fr) for better space utilization
  • Fixed column alignment by:
    • Removing justify-content: space-between
    • Adding gap: 0 to grid layout
    • Standardizing padding to 8px 16px
  • Added dark mode styling for mobile card view (< 1024px screens):
    • Dark card backgrounds (#232946)
    • Dark headers (#1C2541)
    • Purple-blue status badges (#5A67D8)
    • White text throughout
  • Added dark mode styling for "Clear Filters" button
  • Fixed profile picture sizing to 30px × 30px circles with proper spacing
  • Updated mock data to use colorful placeholder images with initials instead of default avatar
  • Updated test file to work with CSS modules (finding elements by content instead of class names)

How to test:

  1. Check out current branch: Juhitha_fix_people_report_page_UI

  2. Run npm install to ensure all dependencies are installed

  3. Clear site data/cache in browser (DevTools → Application → Clear storage)

  4. Run the app locally: npm start

  5. Log in as Admin or Owner user

  6. Navigate to: ReportsReportsPeople tab

  7. Click on any user name to view their report

  8. Verify Desktop View (> 1024px):

    • Task column is significantly wider than before
    • Other columns (Priority, Status, Start Date, End Date) are narrower
    • All columns align properly with their headers
    • Profile pictures are small circles (30px)
    • No white space/gaps between columns
  9. Verify Mobile View (< 1024px):

    • Resize browser window to less than 1024px width
    • Tasks display as cards instead of table rows
    • Each card shows all task information
  10. Verify Dark Mode:

    • Enable dark mode in application settings
    • Desktop view: Check that table maintains proper dark mode colors
    • Mobile view: Verify:
      • Cards have dark background (#232946)
      • Headers have darker background (#1C2541)
      • Status badges are purple-blue
      • All text is white and readable
      • "Clear Filters" button has dark background with white text
    • Toggle filters and verify "Clear Filters" button has proper dark mode styling
  11. Verify Filters:

    • Test various filter combinations
    • Click "Clear Filters" button - should reset all filters
    • In dark mode, button should have dark background with white text

Screenshots or videos of changes:

Uploading Screen Recording 2025-12-19 at 1.48.58 PM.mov…

Desktop View - Light Mode:

  • Task column is wider
  • Columns properly aligned
  • Profile pictures sized correctly

Mobile View - Dark Mode:

  • Dark card backgrounds
  • White text
  • Proper contrast and readability

Clear Filters Button:

  • Light mode: White background, purple text
  • Dark mode: Dark background, white text

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 27, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit d29f73b
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69d30b40adb79a0008b8a402
😎 Deploy Preview https://deploy-preview-4635--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

While testing in dark mode, I noticed a couple of small UI things:

  1. The page header text and person names were a bit hard to read due to low contrast.
  2. The profile toggle/icon area on the right side also looks slightly off in dark mode. The circle outline and alignment feel a little inconsistent with the rest of the theme.

Could you please take a look at these in dark mode and adjust the styling for better consistency and contrast?

Thanks! Let me know once updated.

Image Image Image Image Image Image Image Image Image

@Juhitha-Reddy
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-03-02 at 12 49 01 AM Screenshot 2026-03-02 at 12 49 23 AM Updated the dark mode.

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

Thank you for working on the People Report page UI updates. I tested the PR locally by following the provided steps. Most of the layout changes look good.

However, in dark mode, the toggle under the hours donut chart has text appearing behind it, which affects visibility. Also, the Time Entries graph section appears to have a light background that does not match the rest of the dark theme. Please confirm if the graph styling is part of this PR.

Image Image

@Juhitha-Reddy
Copy link
Copy Markdown
Contributor Author

Hi @HemanthNidamanuru,
Thank you for testing the PR and for the feedback!
The scope of this ticket was focused on the table alignment and block layout adjustments on the People Report page. The two issues you mentioned — the toggle text visibility in dark mode and the Time Entries graph background not matching the dark theme — fall outside the scope of this PR.
Regarding the toggle text visibility, I believe this is a pre-existing component-level bug that was present before my changes. It would be best addressed as a separate bug ticket.
As for the Time Entries graph styling, that was not part of the ticket I picked up, so it was intentionally left untouched.

Happy to discuss further if needed!

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

I have reviewed your PR locally and although most of the UI requirements have been satisfied, found two issues:

  • in dark mode we cannot see the text of the checkbox options
  • the profile image is not circular as per your mention in description
    Issues
Image Image

Working screenshots
Image
Image
Image

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the updated comment:

Hi Juhitha, thank you for working on these improvements! I reviewed your PR locally and while most of the UI requirements are met, I noticed a couple of issues:

  1. In dark mode, the headings in "Tasks with Completed Hours" are not clearly visible
  2. The dropdowns in "Tasks Contributed" appear misaligned
  3. The profile picture is not displaying in a circle shape
  4. The background is still appearing in light mode when dark mode is enabled
Image Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

I suppose the fixes broke the working functionality. Below are the issues found:

  • The profile picture is not displaying in a circle shape and the active/inactive circle does not seem to exist beside the picture
  • The dropdowns in "Tasks Contributed" appear misaligned and do not seem to work
  • Few of the dropdowns in "Tasks Contributed" are not visible in dark mode
  • The background is still appearing in light mode when dark mode is enabled
  • In dark mode, the headings in "Tasks with Completed Hours" are not clearly visible
  • The toggle is not visible in "Time Logged to Projects chart" in dark mode
  • The toggle is not visible in "Tasks with Completed Hours"
  • Mobile resolution needs fixing mainly in both the chart tabular data
Image Image Image Image

@penumalli-juhitha-reddy
Copy link
Copy Markdown

Hi @Anusha-Gali, I have reverted the changes, as the previous description was a bit misleading.
The description based on the ticket requirements:
• Increase the width of the “Task” column, as it is currently too narrow.
• Reduce the width of the other columns.
• Adjust all columns to fit the full page width.
• Update the background and text colors of the Tasks table in dark mode (especially on smaller screens) to match the overall theme.

I believe these items are now resolved, along with the previously mentioned points.
Please have a look considering the scope of the ticket mentioned

@penumalli-juhitha-reddy
Copy link
Copy Markdown

@Anusha-Gali , @HemanthNidamanuru

The PR description was a bit misleading, and I had added a few points that were not part of the original requirements. Please refer to this comment for the correct ticket description.
• Increase the width of the “Task” column, as it is currently too narrow.
• Reduce the width of the other columns.
• Adjust all columns to fit the full page width.
• Update the background and text colors of the Tasks table in dark mode (especially on smaller screens) to match the overall theme.
I apologies for the confusion created

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 6, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

thank you for updating the instructions. I have reviewed your PR locally and noticed a few issues:

  1. The status dropdown background and text color are not updated for dark mode.
  2. The filter fields above the table appear misaligned.
Image Image

@HemanthNidamanuru HemanthNidamanuru dismissed their stale review April 7, 2026 01:25

Submitting request for changes as the previous approval was made by mistake.

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

thank you for updating the instructions. I have reviewed your PR locally and noticed a few issues:

The status dropdown background and text color are not updated for dark mode.
The filter fields above the table appear misaligned.

Image Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha,

Thank you for the updated information. All points appear to have been met except of - Update the background and text colors of the Tasks table in dark mode (especially on smaller screens) to match the overall theme - the tasks table dropdown's are not adapted to dark mode.

Image Image Image Image Image Image

Copy link
Copy Markdown

@rajanidi1999 rajanidi1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I reviewed the PR locally and verified the updates to the People Report page UI. The overall layout improvements look good and align well with the expected design

Image Image Image

Copy link
Copy Markdown

@rithika-paii rithika-paii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhita,
I reviewed PR #4635 and tested the People Report page locally in light mode, dark mode, desktop, and mobile views. The overall responsiveness and styling improvements work well, but I found a couple of issues/suggestions:
1. Filter/Search input issue: On my side, the text box is not accepting typed input properly, so I’m unable to use the field as expected. (See attached video)

PR.4635.-.Light.mode.changes.mov

2. Mobile alignment: The mobile view is generally responsive and usable, but some alignment could still be improved for a cleaner layout. (See attached video.)

PR.4635.-.Mobile.view.-.dark.mode.changes.mov

3. Bottom report option alignment: The 7 report option buttons/sections at the bottom (People / Teams / Projects area) do not appear well-aligned visually. Functionally, they work, but the layout feels uneven and could be improved for better UI consistency. (See attached screenshot.)

Image

Copy link
Copy Markdown

@kunchalasireesha kunchalasireesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Juhitha, it looks like this PR currently has merge conflicts with the base branch. Could you please rebase or merge the latest changes from development into your branch and resolve the conflicts? Once the build passes, I’ll finish the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants