Adithya hotfix popularity url fix#4644
Merged
one-community merged 1 commit intodevelopmentfrom Jan 4, 2026
Merged
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
added
the
High Priority - Please Review First
Anusha-Gali
approved these changes
Jan 2, 2026
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Adithya,
I have reviewed your PR and thanks for updating the url.
rohanrastogi311
approved these changes
Jan 3, 2026
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Adithya,
Well done with this implementation. Good job.
Member
|
Thank you all, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hotfix: Resolves a critical issue in the recently merged Enhanced Popularity Analytics dashboard (PR #4416) where hardcoded
localhostURLs prevented the chart from fetching data in Development and Production environments.This PR replaces the hardcoded fetch URLs in
EnhancedPopularityTimelineChart.jsxwith the dynamicENDPOINTSutility to ensure the application correctly uses the environment-specific API URL (e.g.,https://api-staging.highestgood.com). It also corrects a path formatting issue insrc/utils/URL.jsthat was causing double/api/api/segments in requests.Related PRS
Main changes explained:
src/components/.../EnhancedPopularityTimelineChart.jsx: Removed hardcodedhttp://localhost:4500strings. ImplementedENDPOINTSimport to fetch data dynamically based on the environment configuration.src/utils/URL.js: FixedENHANCED_POPULARITY,ENHANCED_POPULARITY_ROLES, andENHANCED_POPULARITY_PAIRSURL strings to remove redundant/apisegments, preventing 404 errors caused by "double API" paths.How to test:
developmentbackend code) andnpm starton frontend.http://localhost:5173/popularity-enhanced.Screenshots or videos of changes:
(UI remains identical to the original feature implementation; this is a logic fix only.)
Enhanced.Popularity.Timeline.mp4
Note:
Please mute the audio of this recording. Timer sounds have been recorded.