uha optimize darkmode fix#4696
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
uhakruthi1
changed the title
|
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Uha,
I have reviewed your PR locally and it works as expected in dark mode.
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Uha,
Dark mode looks fine on the main page as well as update record page, however, the page goes into error state on all the purchase records below the second record.
uhakruthi1
force-pushed
the
593-darkmode-dix-3161
branch
from
00e035b to
4553257
Compare
# Conflicts: # src/components/BMDashboard/ItemList/ItemListView.jsx # src/components/BMDashboard/ItemList/ItemListView.module.css # src/components/BMDashboard/ItemList/ItemsTable.jsx # src/components/BMDashboard/ItemList/SelectForm.jsx # src/components/BMDashboard/ItemList/SelectItem.jsx # yarn.lock
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
HI Uha,
Having a failure to launch.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi uha,
I have reviewed your PR locally and the UI is as per requirement in the dark mode.
# Conflicts: # yarn.lock
|
|
Thank you all, merging! |
4 participants
Description
Related PRS (if any):
frontend - #3161
How to test:
check into current branch
do npm install and npm start to run this PR locally
Clear site data/cache
log as admin user
go to “/bmdashboard/materials”
view update and purchase models
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.