Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
added
the
High Priority - Please Review First
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Vinay,
I tested this PR locally. The chart renders correctly on filter selection and hover is working. One thing I noticed, the tooltip borders are merging with the background and alignment looks off in dark mode. Does dark mode compatibility fall under this PR's scope?
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Vinay,
I have reviewed your PR locally and the hover tooltip works in both the modes and with filters.
Note: Do check if you could reduce the size of the text in tooltip such that it could avoid touching the chart border before resolving merge conflicts.
Vinay944924
force-pushed
the
vinay_graph_hover
branch
from
15fea57 to
7c6e94c
Compare
|
4 participants
Description
Related PRS (if any):
This frontend PR is related to the #1405 backend PR.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Video.mov
Note:
If the backend does not work make changes in the db.js file to the current backend development db.js file.