uha sms LB frontend changes redo of 4438#4700
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
one-community
changed the title
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Uha,
I have reviewed your PR locally and though all functionalities do work as expected, the only issue is the notification. Do let me know if it is an issue from my end.
4700.mp4
| * @param {*} user - the user to be deleted | ||
| * @param {*} option - archive / delete | ||
| */ | ||
| export const deleteUser = (user, option) => { |
There was a problem hiding this comment.
The deleteUser function removes users from UI even when API delete fails , causing confusion when deleted users reappear after refresh
| * @param {*} option - archive / delete | ||
| */ | ||
| export const deleteUser = (user, option) => { | ||
| const requestData = { option, userId: user._id }; |
There was a problem hiding this comment.
Use the optimistic UI only to implement rollback.
|
Tested the functionality locally which works as expected but unable to receive any notifications at my end. |
uhakruthi1
force-pushed
the
frontend-messaging
branch
2 times, most recently
from
46fa39b to
7cad209
Compare
rajanidi1999
left a comment
rajanidi1999
left a comment
There was a problem hiding this comment.
Hi,
I have tested your PR review its running successfully.
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Uha,
Thank you for fixing the notification issue. The feature works as per requirement.
4700.mov
# Conflicts: # package-lock.json # src/components/Header/Header.module.css
uhakruthi1
dismissed stale reviews from Anusha-Gali and rajanidi1999
via
cc56fe3
|
|
Thank you all, merging! |
7 participants
Description
PR4438 was closed because it introduced a breaking issue. The work was redone and resubmitted in PR#4700 with the fixes applied.
Related PRS (if any):
This frontend PR is related to the PR#1999 backend PR.
Related PRs : PR1366, PR3476, PR#3311 , PR#1289
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
video2273694593.mp4
Note:
SMS notification support has been implemented as part of this work. However, the SMS provider requires a paid account for sending messages in the US, so end-to-end SMS delivery could not be fully tested in a live environment. The integration logic is in place and can be validated once a test or paid account is available.