Shravya/bugfix-addLostTime-teams/3824#4738
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
ShravyaKudlu
added
the
High Priority - Please Review First
ShravyaKudlu
changed the title
There was a problem hiding this comment.
Hi Shravya,
I tried to review your PR locally and after waiting for more than 4 mins, logging out and logging in and re-running the PR again. I am not able to see the lost time i have added.
Below image is to show an estimate of wait time, after the first three screenshots, after re-running the next two screenshots were taken yet you can see changes not reflecting
rajanidi1999
left a comment
rajanidi1999
left a comment
There was a problem hiding this comment.
Hi,
I have reviewed your PR and its running successfully.
|
@Anusha-Gali — Getting an unauthorized request error for both Projects and Teams when trying to add lost time. This was working fine before. The only change I made was fixing the submit button for Add Lost Time (Teams) — it wasn't visible and wasn't mapped to the correct API endpoint, seems like the API endpoints in the backend have been changed or not authorized. Will need some time to investigate and fix this. Will keep you updated. 
|
rithika-paii
left a comment
rithika-paii
left a comment
There was a problem hiding this comment.
Hi Shravya,
I reviewed PR #4738 and tested the Add Lost Time flow under Reports → Teams. The feature works as expected, and add/update/delete actions reflect correctly after the expected delay.
No issues observed from my testing.
ShravyaKudlu
dismissed stale reviews from rithika-paii and rajanidi1999
via
571ba16
|
4 participants
Description
Fixes #3824
1028 Fix and Complete PR 3824
Related PRS (if any)
This frontend PR is related to the development backend.
Main changes explained
The main changes are to addlosttime.jsx and addteams.jsx
Basically the functionality working for project
while adding lost time wasnt working for teams
How to test
npm installand...to run this PR locally\reportsit will take more then 4 min to reflects
Screenshots or videos of changes
https://github.com/user-attachments/assets/f40bf247-d792-41ec-ae36-4c8ef706e0ab
Note
The time lag was part of the previous part #3824, it takes more the 4 min to reflect, for anything, add, delete, update