Skip to content

Aayush Optimize Field Dependency & Selection Flow#4806

Merged
one-community merged 4 commits intodevelopmentfrom
optimize_equipment_update
Apr 18, 2026
Merged

Aayush Optimize Field Dependency & Selection Flow#4806
one-community merged 4 commits intodevelopmentfrom
optimize_equipment_update

Conversation

@aayushshetty12
Copy link
Copy Markdown
Contributor

@aayushshetty12 aayushshetty12 commented Feb 7, 2026

Description

Screenshot 2026-02-07 025311

Related PRS (if any):

Main changes explained:

  • Updated EquipmentUpdateForm.jsx for filter fix and drop-down dependency check

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /bmdashboard/Tools/EquipmentUpdate
  6. Fill the form and check dropdown checks and filters

Note:

No equipments available is a fallback for no data in API response

Screenshots or videos of changes:

Recording.2026-02-07.025910.mp4

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 7, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 894696a
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69e333c82814c100087dcaf7
😎 Deploy Preview https://deploy-preview-4806--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 7, 2026

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 3, 2026
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aayush,

Can't select equipment.

Image

Anusha-Gali
Anusha-Gali previously approved these changes Apr 8, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aayush,

I have reviewed your PR locally and would like to point out two issue.

  • The requirement mentioned that the dropdown's should be disabled until prerequisite selections are made, but i am able to select tool before project - let me know if it is to be allowed
  • Upon selecting equipment, unable to select any name and update it.
4806.mov

@aayushshetty12
Copy link
Copy Markdown
Contributor Author

@rohanrastogi311 @Anusha-Gali

The field itemType used to populate the equipment is coming back as null in the response. Because of that, there’s no data for the frontend to render.

I’ve added a fallback so the UI handles this case gracefully (No name available), and if this field is expected to contain values, the issue is upstream in the API response or data.

@sonarqubecloud
Copy link
Copy Markdown

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit 2cc2737 into development Apr 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants