Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 37 additions & 15 deletions src/components/BMDashboard/Tools/EquipmentUpdateForm.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,21 @@
const toolList = useMemo(
() =>
tools
.filter(tool => tool.itemType && tool.itemType.name)
.filter(
tool => tool.project._id === formData.project && tool.itemType && tool.itemType.name,

Check warning on line 37 in src/components/BMDashboard/Tools/EquipmentUpdateForm.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZ2ffhISWySueEBaGxAH&open=AZ2ffhISWySueEBaGxAH&pullRequest=4806
)
.map(tool => ({ id: tool.itemType._id, name: tool.itemType.name })),
[tools],
[tools, formData.project],
);

const equipmentList = useMemo(
() =>
equipments
.filter(equip => equip.itemType && equip.itemType.name)
.filter(
equip => equip.project._id === formData.project && equip.itemType && equip.itemType.name,

Check warning on line 47 in src/components/BMDashboard/Tools/EquipmentUpdateForm.jsx

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read.

See more on https://sonarcloud.io/project/issues?id=OneCommunityGlobal_HighestGoodNetworkApp&issues=AZ2ffhISWySueEBaGxAI&open=AZ2ffhISWySueEBaGxAI&pullRequest=4806
)
.map(equip => ({ id: equip.itemType._id, name: equip.itemType.name })),
[equipments],
[equipments, formData.project],
);
const uniqueToolList = useMemo(
() => [...new Map(toolList.map(item => [item.id, item])).values()],
Expand Down Expand Up @@ -73,7 +77,7 @@
setFormData(prev => ({
...prev,
[name]: value,
...(name === 'toolOrEquipment' ? { name: '', number: '' } : {}), // Reset name and number on change
...(name === 'project' || name === 'toolOrEquipment' ? { name: '', number: '' } : {}), // Reset name and number on change
}));
};

Expand Down Expand Up @@ -158,21 +162,39 @@
onChange={handleChange}
disabled={!formData.toolOrEquipment}
>
<option value="">Select Name</option>
{formData.toolOrEquipment === 'Tool' &&
uniqueToolList.map(item => (
<option key={item.id} value={item.name}>
{item.name}
</option>
(uniqueToolList.length > 0 ? (
<>
<option value="">Select Name</option>
{uniqueToolList.map(item => (
<option key={item.id} value={item.name}>
{item.name}
</option>
))}
</>
) : (
<option value="">No names available</option>
))}
{formData.toolOrEquipment === 'Equipment' &&
uniqueEquipmentList.map(item => (
<option key={item.id} value={item.name}>
{item.name}
</option>
(uniqueEquipmentList.length > 0 ? (
<>
<option value="">Select Name</option>
{uniqueEquipmentList.map(item => (
<option key={item.id} value={item.name}>
{item.name}
</option>
))}
</>
) : (
<option value="">No names available</option>
))}
</Input>
{!formData.name && <div className={styles.toolFormError}>Please select a name</div>}
{!formData.name &&
(!formData.toolOrEquipment || !formData.project ? (
<div className="toolFormError">Please select Project and Tool/Equipment first</div>
) : (
<div className="toolFormError">Please select a name</div>
))}
</FormGroup>

<FormGroup>
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12553,4 +12553,4 @@ yocto-queue@^0.1.0:
yoctocolors-cjs@^2.1.2:
version "2.1.3"
resolved "https://registry.npmjs.org/yoctocolors-cjs/-/yoctocolors-cjs-2.1.3.tgz"
integrity sha512-U/PBtDf35ff0D8X8D0jfdzHYEPFxAI7jJlxZXwCSez5M3190m+QobIfh+sWDWSHMCWWJN2AWamkegn6vr6YBTw==
integrity sha512-U/PBtDf35ff0D8X8D0jfdzHYEPFxAI7jJlxZXwCSez5M3190m+QobIfh+sWDWSHMCWWJN2AWamkegn6vr6YBTw==
Loading