Chirag - Fixed the navigation links on Event Cards#4882
Chirag - Fixed the navigation links on Event Cards#4882ChiragBellara wants to merge 5 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Set error state when date parsing fails.
Refactor date parsing logic to remove redundant error handling.
|
one-community
changed the title
one-community
added
the
High Priority - Please Review First
rohanrastogi311
left a comment
rohanrastogi311
left a comment
There was a problem hiding this comment.
Hi Chirag,
Well done with this, however, it came up with an error after redirecting.
There was a problem hiding this comment.
Hi Chirag,
I have reviewed your PR locally and the redirection does work as per your video however as far as i know there is a PR which has all the events which can be redirected to via this PR hence wondering why is there no link to the actual URL and a link to a page which essentially does not say what the event is about.
|
4 participants
Description
Related PRS (if any):
This is NOT related to any other PRs
Main changes explained:
How to test:
npm installandnpm run start:localto run this PR locally/communityportal/communityportal/activities/Register/<ID>Screenshots or videos of changes:
Event.Card.Navigation.Fix.mov
Notes
The redirection on the cards currently leads to a error 404 because the registration screen previously made is static. I am working on updating the screen to work dynamically with the event IDs. For now, please check that the URL changes for each card and the screen does redirect to a new screen with the url
/communityportal/activities/Register/<ID>