Skip to content

Roshini Seelamsetty: Volunteer Hours Distribution Chart Shows Incorrect Totals and Misleading Visualization#4913

Open
roshini1212 wants to merge 21 commits intodevelopmentfrom
roshini/volunteer-hours-distribution-chart-visualization-fix
Open

Roshini Seelamsetty: Volunteer Hours Distribution Chart Shows Incorrect Totals and Misleading Visualization#4913
roshini1212 wants to merge 21 commits intodevelopmentfrom
roshini/volunteer-hours-distribution-chart-visualization-fix

Conversation

@roshini1212
Copy link
Copy Markdown

@roshini1212 roshini1212 commented Feb 27, 2026

Description

Fixes Yagna PRIORITY HIGH: Volunteer Hours Distribution Chart Shows Incorrect Totals and Misleading Visualization

Screenshot 2026-03-17 at 02 11 43

Summary: Redesigned pie chart to show volunteer counts per hour range (not misleading hour values). Fixed center total, 40+/50+ buckets, tooltips, and percentage labels.

Main changes explained:

  • VolunteerHoursDistribution.jsx: formatRangeLabel(), HoursWorkList w/ counts, userData w/ percentages
  • HoursWorkedPieChart.jsx: Center = totalHoursData.current (Leaderboard), tooltipType="hoursDistribution"
  • NumbersVolunteerWorked.jsx: "X volunteers (Y%) logged Z+ hours..."
  • CustomTooltip.jsx: Volunteers + % display
  • Tests: Full coverage + PropTypes

How to test:

  1. git checkout roshini/volunteer-hours-distribution-chart-visualization-fix in frontend
  2. Run npm run start:local
  3. Owner login → Reports → Total Org Summary
  4. Verify: volunteer counts, Leaderboard total, 40-49→50+, hover tooltip
  5. npm test

Screenshots:

BEFORE:
Before

Screen.Recording.2026-02-26.at.15.12.04.mov

AFTER:

PR.4913.Light.Mode.mov
PR.4913.Dark.Mode.mov

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 27, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 51b6b26
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69e2b2e82b9f3200083bb71b
😎 Deploy Preview https://deploy-preview-4913--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 14, 2026
@roshini1212 roshini1212 changed the title Roshini/volunteer hours distribution chart visualization fix Roshini Seelamsetty/volunteer hours distribution chart visualization fix Mar 15, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,

Great work! All values look correct. Just noticed the pie chart labels are a bit off, some are cut off or not centered within their slices. Worth fixing the text positioning. Does this fall under the scope of this PR?

Image Image Image Image Image Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,

I have reviewed your PR locally, though the main functionality works as per requirement have found the below issues:

  • The chart data labels are not compatible to dark mode
  • The chart data labels overlap in case of bigger numerical values
  • The Total Hours Worked label is extended into to the graph
Image Image Image Image Image

@roshini1212 roshini1212 changed the title Roshini Seelamsetty/volunteer hours distribution chart visualization fix Roshini Seelamsetty: (PRIORITY HIGH) Yagna: Volunteer Hours Distribution Chart Shows Incorrect Totals and Misleading Visualization Mar 18, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,
I have reviewed your PR locally. The main functionality works as expected, however I noticed a few issues:

  1. The Total Hours Worked label extends into the graph area
  2. The chart data labels overlap when the numerical values are larger
Image Image Image

@HemanthNidamanuru HemanthNidamanuru dismissed their stale review March 20, 2026 14:07

I approved the changes accidentally.

Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,
I have reviewed your PR locally. The main functionality works as expected, however I noticed a few issues:

The Total Hours Worked label extends into the graph area
The chart data labels overlap when the numerical values are larger

Image Image Image

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,

The arrows don't function in dark mode (and look tacky). There's some clipping occurring with the numbers too.

Image Image

@roshini1212 roshini1212 force-pushed the roshini/volunteer-hours-distribution-chart-visualization-fix branch from 552feb8 to d70c366 Compare March 28, 2026 19:08
RoshiniSeelamsetty added 19 commits March 28, 2026 19:56
Changes:
- Volunteer counts + % slices/legend
- Center: Leaderboard total hours ✅
- Tooltips: 'Volunteers X, % Y'
- Buckets: 40-49 → 50+
- Tests: 100% coverage + PropTypes
- UX: formatRangeLabel(), guards
…Incorrect Totals and Misleading Visualization
@roshini1212 roshini1212 force-pushed the roshini/volunteer-hours-distribution-chart-visualization-fix branch from d70c366 to 36aaa7b Compare March 29, 2026 00:15
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,

I have reviewed your PR locally. The main functionality works as expected, however I noticed a few issues:

  1. Percentage labels are missing on the smaller pie slices.
  2. The hover tooltip is misaligned and not styled correctly in dark mode.
Image Image

Anusha-Gali
Anusha-Gali previously approved these changes Apr 10, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roshini,

Thank you for making the suggested changes, i have reviewed your PR locally and it works as per requirement.

Image Image Image Image Image Image Image

@roshini1212 roshini1212 changed the title Roshini Seelamsetty: (PRIORITY HIGH) Yagna: Volunteer Hours Distribution Chart Shows Incorrect Totals and Misleading Visualization Roshini Seelamsetty: Volunteer Hours Distribution Chart Shows Incorrect Totals and Misleading Visualization Apr 14, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants