Sayali: dark mode visibility for reviewer name in PR grading dashboard#4951
Merged
one-community merged 1 commit intodevelopmentfrom Mar 24, 2026
Merged
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Vishnu10-hub
approved these changes
Mar 6, 2026
Vishnu10-hub
left a comment
There was a problem hiding this comment.
Hi Sayali,
-
Checked out the branch from the development branch and ran the application locally.
-
Navigated to /pr-grading-dashboard and tested the screen in both light and dark mode.
-
Verified that reviewer names are visible in the Reviewer Name column and the PRs Reviewed input fields are clearly visible in dark mode.
-
Confirmed that light mode still looks correct and the screen remains readable.
Member
|
Thank you all, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #38 (Priority Low)
Dark mode bug fix — reviewer names in the Reviewer Name column were not visible (appearing as black squares) in dark mode on the PR Grading Dashboard page on development.
Related PRs:
Related to PR #4842, #4533
Main changes explained:
ReviewerRow.jsxto acceptdarkModeprop and apply inline dark mode styles to reviewer name button and PRs reviewed inputReviewerRow.module.cssto addbackground: none; border: none; padding: 0;to.reviewerNamebutton and fixed allrgba()to modernrgb()notation for stylelint complianceGradingTable.jsxto accept and passdarkModeprop toReviewerRow, added PropTypesPRGradingDashboard.jsxto readdarkModefrom Redux store viauseSelectorand pass it down toGradingTableHow to test:
Sayali_PR_Grading_Task_38_DarkMode_ReviewerNamenpm install && npm run start:localhttp://localhost:5173/pr-grading-dashboardScreenshots:
Note:
The root cause was that
PRGradingDashboardhad no access to the ReduxdarkModestate, so dark mode styles were never applied to child components. Fixed by readingdarkModefrom Redux and passing it down the component tree.