Skip to content

Sayali: dark mode visibility for reviewer name in PR grading dashboard#4951

Merged
one-community merged 1 commit intodevelopmentfrom
Sayali_PR_Grading_Task_38_DarkMode_ReviewerName
Mar 24, 2026
Merged

Sayali: dark mode visibility for reviewer name in PR grading dashboard#4951
one-community merged 1 commit intodevelopmentfrom
Sayali_PR_Grading_Task_38_DarkMode_ReviewerName

Conversation

@sayali-2308
Copy link
Copy Markdown
Contributor

image

Description

Fixes #38 (Priority Low)
Dark mode bug fix — reviewer names in the Reviewer Name column were not visible (appearing as black squares) in dark mode on the PR Grading Dashboard page on development.

Related PRs:

Related to PR #4842, #4533

Main changes explained:

  • Updated ReviewerRow.jsx to accept darkMode prop and apply inline dark mode styles to reviewer name button and PRs reviewed input
  • Updated ReviewerRow.module.css to add background: none; border: none; padding: 0; to .reviewerName button and fixed all rgba() to modern rgb() notation for stylelint compliance
  • Updated GradingTable.jsx to accept and pass darkMode prop to ReviewerRow, added PropTypes
  • Updated PRGradingDashboard.jsx to read darkMode from Redux store via useSelector and pass it down to GradingTable

How to test:

  1. Check out branch Sayali_PR_Grading_Task_38_DarkMode_ReviewerName
  2. npm install && npm run start:local
  3. Clear cache, log in as admin
  4. Navigate to http://localhost:5173/pr-grading-dashboard
  5. Switch to dark mode
  6. Verify reviewer names are visible in the Reviewer Name column
  7. Verify PRs Reviewed input fields are visible in dark mode
  8. Verify light mode still looks correct

Screenshots:

image image

Note:

The root cause was that PRGradingDashboard had no access to the Redux darkMode state, so dark mode styles were never applied to child components. Fixed by reading darkMode from Redux and passing it down the component tree.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 6, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit d39ac6c
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69aa7878915daf000838d5eb
😎 Deploy Preview https://deploy-preview-4951--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 6, 2026

Copy link
Copy Markdown

@Vishnu10-hub Vishnu10-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sayali,

  • Checked out the branch from the development branch and ran the application locally.

  • Navigated to /pr-grading-dashboard and tested the screen in both light and dark mode.

  • Verified that reviewer names are visible in the Reviewer Name column and the PRs Reviewed input fields are clearly visible in dark mode.

  • Confirmed that light mode still looks correct and the screen remains readable.

Image Image

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit cc10b64 into development Mar 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants