Skip to content

Deekshith : Fix dark mode styling for PR reviewer promotion modal#4973

Closed
Deekshith010905 wants to merge 1 commit intodevelopmentfrom
DarkModeStyling
Closed

Deekshith : Fix dark mode styling for PR reviewer promotion modal#4973
Deekshith010905 wants to merge 1 commit intodevelopmentfrom
DarkModeStyling

Conversation

@Deekshith010905
Copy link
Copy Markdown
Contributor

@Deekshith010905 Deekshith010905 commented Mar 11, 2026 •
edited
Loading

Description

Problem:
image

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/prPromotionsPage

Screenshots or videos of changes:

HGN.APP.-.Google.Chrome.2026-03-11.02-24-49.mp4

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 11, 2026 •
edited
Loading

❌ Deploy Preview for highestgoodnetwork-dev failed.

Name Link
🔨 Latest commit 8261923
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69c0d97ee636080008ac7764

@Deekshith010905 Deekshith010905 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Mar 11, 2026
HemanthNidamanuru
HemanthNidamanuru previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deekshith,

I tested this PR locally and everything works as expected.
The modal is clearly readable in dark mode and there are no issues in light mode.

Image Image

Anusha-Gali
Anusha-Gali previously approved these changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deekshith,

I have reviewed your PR locally and the styling is as per requirement.

Image Image

rohanrastogi311
rohanrastogi311 previously approved these changes Mar 15, 2026
View reviewed changes
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deekshith,

Well done with this implementation.

Image

ManojPuttaswamy
ManojPuttaswamy previously approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown

@ManojPuttaswamy ManojPuttaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark mode styling for promotion modal work as expected.

Image Image

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 23, 2026

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Anusha-Gali
Anusha-Gali approved these changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deekshith,

I have reviewed your PR locally and it works as per requirement

Image

rajanidi1999
rajanidi1999 approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown

@rajanidi1999 rajanidi1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Deekshith,
I have reviewed your PR locally and its running successfully
image

@one-community
Copy link
Copy Markdown
Member

one-community commented Apr 18, 2026

Redone with this PR: #5159

@one-community
Copy link
Copy Markdown
Member

one-community commented Apr 18, 2026

Redo is here: #5159

@one-community one-community mentioned this pull request Apr 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajanidi1999 rajanidi1999 rajanidi1999 approved these changes

@rohanrastogi311 rohanrastogi311 rohanrastogi311 left review comments

@ManojPuttaswamy ManojPuttaswamy ManojPuttaswamy left review comments

@HemanthNidamanuru HemanthNidamanuru HemanthNidamanuru left review comments

+1 more reviewer

@Anusha-Gali Anusha-Gali Anusha-Gali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Deekshith010905 @one-community @rohanrastogi311 @Anusha-Gali @ManojPuttaswamy @HemanthNidamanuru @rajanidi1999