Handika taking over for Alisha - fix(job-analytics): improve tooltip data clarity for application time…#5043
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
There was a problem hiding this comment.
Looks good overall,
Just one accessibility suggestion: the .bar div is interactive (hover/tooltip), so it should ideally support keyboard access (e.g., tabIndex, role="button", and focus/blur handlers).
Also noticed a few duplicate CSS properties that could be cleaned up.
Otherwise, great work on the tooltip behavior and positioning
4cb7b27
062381f to
4cb7b27
Compare
rithika-paii
left a comment
There was a problem hiding this comment.
Hi Alisha,
I reviewed the PR #5043 locally, and it works well! No changes required from my side!
PR.5043.mov
|
This feature works as intended and the code is great |
kunchalasireesha
left a comment
There was a problem hiding this comment.
Hi Alisha, it looks like this PR currently has merge conflicts with the base branch. Could you please rebase or merge the latest changes from development into your branch and resolve the conflicts? Once the build passes, I’ll finish the review.
1ebe61b
55e19d7 to
1ebe61b
Compare
|
1ebe61b to
9d48a60
Compare
9d48a60 to
c7cf151
Compare
|
amaresh2001
left a comment
There was a problem hiding this comment.
Tested locally on alisha/fix/application-time-chart-tooltip-data-clarity.
Testing:
- Hovering over a bar displays a tooltip with the role name, average time (in minutes), and total number of applications.
- Tooltip updates correctly when hovering over different bars.
- Role filter works correctly, and tooltips remain accurate after filtering.
- Dark mode is fully supported. Tooltip text and background are readable.
Issue:
- Merge conflicts must be resolved before merging.
Mahitha-pasupuleti
left a comment
There was a problem hiding this comment.
Hi Alisha,
I reviewed and tested this PR. The tooltip is displayed correctly when hovering over the bars in the Application Time Chart and accurately shows the role name, average time (in minutes), and total number of applications.
I also verified the functionality in both light mode and dark mode. The tooltip is displayed properly, remains readable, and works as expected across themes.
Everything is functioning according to the requirements. Approving this PR.
Abhi-R0211
left a comment
There was a problem hiding this comment.
Checked out the PR branch and navigated to http://localhost:5173/application-time-chart.
Results
Tooltip - Hover behavior (light mode)
Hovering over bars correctly displays the tooltip with role name, average time (in minutes), and total number of applications. Tested across multiple bars, each tooltip correctly reflects the data for that specific role.
Role filter
Selecting a specific role from the Role dropdown correctly filters the chart to show only that role, and the tooltip data remains accurate.
Date filter - data unchanged after filter change
After changing the Dates dropdown (e.g. from ALL to Last 7 Days), the chart data did not change. This may be a pre-existing data issue unrelated to this PR rather than a regression introduced here - the tooltip itself continues to display correctly for whatever data is shown.
Light mode
Chart renders cleanly in light mode. Title, bars, axis labels, and summary text all display correctly with good contrast.
Dark mode
Toggled dark mode. Chart title, bars, axis labels, and summary text all adapt correctly. No contrast issues or broken styles. Tooltip also displays correctly in dark mode with readable text and appropriate background contrast.
handikaharianto
left a comment
There was a problem hiding this comment.
Hi @alishawalunj , after reviewing your PR, the tooltip has been implemented correctly and includes the necessary information, such as role name, average time, and total number of applications. And it also works properly in both dark/light modes.
YSWFelicity
left a comment
There was a problem hiding this comment.
✅ Tested — Working as expected
Followed the test steps on the PR branch (alisha/fix/application-time-chart-tooltip-data-clarity):
✅ Checked out the PR branch
✅ Ran npm install and started the dev server (npm start)
✅ Cleared site data/cache and logged in as an admin user
✅ Navigated to http://localhost:5173/application-time-chart
Tooltip verification
Hovering over each bar in the chart correctly displays a tooltip with all three required fields:
Role name (e.g. the role label of the hovered bar)
Avg. Time in minutes
Applications (total number of applications)
The tooltip follows the cursor smoothly and stays within the viewport (doesn't get clipped at the chart edges). Values update correctly when switching the Dates and Role filters.
Theme verification
☀️ Light mode (white): tooltip text, divider, and background render clearly with good contrast. ✅
🌙 Dark mode (black): toggled dark mode — tooltip and chart styling adapt correctly, text remains readable, no contrast issues. ✅
Result: Tested in both light and dark mode — passed. 👍
AmaanSyed09
left a comment
There was a problem hiding this comment.
Hi Alisha,
I tested the PR locally and verified the following:
-
Tooltip displays the required information: role name, average time in minutes, and total number of applications.
-
Tooltip formatting is clear and readable in both light mode and dark mode.
-
Role filtering works correctly and updates the chart as expected.
-
The page renders correctly in both light mode and dark mode.
Issues Found:
-
The Date filter does not appear to affect the displayed data. I tested multiple date ranges, including Last 7 Days and Last 30 Days, and the chart values, summary statistics, and tooltip data remained unchanged.
-
The PR description states that tooltip data should update dynamically when Date or Role filters are changed. Role filtering works correctly, but I was unable to verify the expected behavior for Date filtering.
-
I also noticed existing code review concerns around unstable keys from uuidv4(), tooltip fade-out behavior, unused hideTimerRef logic, and the totalApplications fallback using || 1 instead of preserving 0 values.
Requesting changes so the Date filter behavior and related tooltip/chart update logic can be fixed or clarified before approval.
Screenshots:
The Date filter doesn't update.
pixelpix13
left a comment
There was a problem hiding this comment.
Hi @alishawalunj, I tested this pr and below are my reviews
Visual Testing
- Tooltip appears on bar hover showing role name, avg time, and application count
- Tooltip repositions correctly near viewport edges
- Filters (Dates + Role) update tooltip data dynamically
- Light mode rendering correct
- Dark mode rendering correct
Code Issues Found
uuidv4()used as map key (lines ~285, ~324) — generates new keys on every render,
causing unnecessary remounts. Should useitem.roleas a stable key.- Tooltip fade-out doesn't animate — element is removed immediately from DOM when
visible=false, bypassing the CSS transition. Tooltip should always be rendered and
only thetooltipVisibleclass should be toggled. hideTimerRefis never assigned —clearTimeoutis called on it but no
setTimeoutis ever set. Dead code.count: item.totalApplications || 1— fallback should be?? 0, not|| 1,
to correctly show 0 applications instead of 1.
05e1a9d
|





















Description
Related PRS (if any):
To test this frontend PR you need to checkout development branch for backend.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes: