Skip to content

Handika taking over for Alisha - fix(job-analytics): improve tooltip data clarity for application time…#5043

Open
alishawalunj wants to merge 9 commits into
developmentfrom
alisha/fix/application-time-chart-tooltip-data-clarity
Open

Handika taking over for Alisha - fix(job-analytics): improve tooltip data clarity for application time…#5043
alishawalunj wants to merge 9 commits into
developmentfrom
alisha/fix/application-time-chart-tooltip-data-clarity

Conversation

@alishawalunj

Copy link
Copy Markdown
Contributor

Description

F77442B5-839A-4A04-A668-E54C4B285696

Related PRS (if any):

To test this frontend PR you need to checkout development branch for backend.

Main changes explained:

  • Update ApplicationTimeChart.jsx for adding tooltip on bar hover displaying role name, average time, and total applications with dynamic filter support
  • Update ApplicationTimeChart.module.css for introducing tooltip styles

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/application-time-chart
  6. verify the tooltip is displayed on hovering over the chart displaying role name, average time (in minutes), and total number of applications

Screenshots or videos of changes:

22CFEE5E-CCD7-4EF4-8EF1-48D4A62E51CF

@netlify

netlify Bot commented Mar 22, 2026

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ca24af8
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a3b35efcd38140008b97f7e
😎 Deploy Preview https://deploy-preview-5043--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community changed the title fix(job-analytics): improve tooltip data clarity for application time… Alisha - fix(job-analytics): improve tooltip data clarity for application time… Apr 6, 2026
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 6, 2026

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I have reviewed your PR locally. The tooltip improvements are working as expected, showing the role name, average time, and total applications correctly.

One observation: the chart title color is not adapting to dark mode.

Image Image

@Anusha-Gali Anusha-Gali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I have reviewed your PR locally and not sure why the dark mode is not working in your PR since it seems to work in Dev, could you pull the latest changes and make sure the toggle is well adapted to dark mode as black background would ideally not work well.

localhost
light mode
Screenshot 2026-04-08 at 9 39 50 PM
dark mode
Screenshot 2026-04-08 at 9 39 56 PM

dev dark mode
Screenshot 2026-04-08 at 9 39 59 PM

rajanidi1999
rajanidi1999 previously approved these changes Apr 12, 2026

@rajanidi1999 rajanidi1999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall,
Just one accessibility suggestion: the .bar div is interactive (hover/tooltip), so it should ideally support keyboard access (e.g., tabIndex, role="button", and focus/blur handlers).
Also noticed a few duplicate CSS properties that could be cleaned up.
Otherwise, great work on the tooltip behavior and positioning

image

@alishawalunj alishawalunj force-pushed the alisha/fix/application-time-chart-tooltip-data-clarity branch from 062381f to 4cb7b27 Compare April 13, 2026 02:33
@alishawalunj

Copy link
Copy Markdown
Contributor Author

Hi Alisha,

I have reviewed your PR locally and not sure why the dark mode is not working in your PR since it seems to work in Dev, could you pull the latest changes and make sure the toggle is well adapted to dark mode as black background would ideally not work well.

localhost light mode Screenshot 2026-04-08 at 9 39 50 PM dark mode Screenshot 2026-04-08 at 9 39 56 PM

dev dark mode Screenshot 2026-04-08 at 9 39 59 PM

The issue is fixed. Please review.

Image 4-12-26 at 10 41 PM

rajanidi1999
rajanidi1999 previously approved these changes Apr 14, 2026

@rajanidi1999 rajanidi1999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@Anusha-Gali Anusha-Gali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

Thanks for fixing the issues. The toggle is now well adapted in both the modes.

Image Image

rithika-paii
rithika-paii previously approved these changes Apr 18, 2026

@rithika-paii rithika-paii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,
I reviewed the PR #5043 locally, and it works well! No changes required from my side!

PR.5043.mov

@beblicarl

Copy link
Copy Markdown
Contributor

This feature works as intended and the code is great

https://www.loom.com/share/c7973cf4250a434eaa9932833e89d2be

@beblicarl beblicarl self-requested a review May 1, 2026 09:23
beblicarl
beblicarl previously approved these changes May 1, 2026
saurabhdipte
saurabhdipte previously approved these changes May 1, 2026

@saurabhdipte saurabhdipte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I reviewed the changes locally and everything works well.

Image

@kunchalasireesha kunchalasireesha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha, it looks like this PR currently has merge conflicts with the base branch. Could you please rebase or merge the latest changes from development into your branch and resolve the conflicts? Once the build passes, I’ll finish the review.

@alishawalunj alishawalunj force-pushed the alisha/fix/application-time-chart-tooltip-data-clarity branch from 55e19d7 to 1ebe61b Compare May 3, 2026 00:29
@sonarqubecloud

sonarqubecloud Bot commented May 3, 2026

Copy link
Copy Markdown

@DeepighaJ DeepighaJ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Checkout to current branch and ran PR locally
Logged in as Owner
When hitting the url following error is displayed.
Image

@alishawalunj alishawalunj force-pushed the alisha/fix/application-time-chart-tooltip-data-clarity branch from 1ebe61b to 9d48a60 Compare May 24, 2026 01:43
@alishawalunj alishawalunj force-pushed the alisha/fix/application-time-chart-tooltip-data-clarity branch from 9d48a60 to c7cf151 Compare May 31, 2026 00:59
@sonarqubecloud

Copy link
Copy Markdown

amaresh2001
amaresh2001 previously approved these changes Jun 5, 2026

@amaresh2001 amaresh2001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on alisha/fix/application-time-chart-tooltip-data-clarity.

Testing:

  • Hovering over a bar displays a tooltip with the role name, average time (in minutes), and total number of applications.
  • Tooltip updates correctly when hovering over different bars.
  • Role filter works correctly, and tooltips remain accurate after filtering.
  • Dark mode is fully supported. Tooltip text and background are readable.

Issue:

  • Merge conflicts must be resolved before merging.
Image Image Image Image Image

@Mahitha-pasupuleti Mahitha-pasupuleti left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I reviewed and tested this PR. The tooltip is displayed correctly when hovering over the bars in the Application Time Chart and accurately shows the role name, average time (in minutes), and total number of applications.

I also verified the functionality in both light mode and dark mode. The tooltip is displayed properly, remains readable, and works as expected across themes.

Everything is functioning according to the requirements. Approving this PR.

Image Image

Abhi-R0211
Abhi-R0211 previously approved these changes Jun 12, 2026

@Abhi-R0211 Abhi-R0211 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the PR branch and navigated to http://localhost:5173/application-time-chart.


Results

Tooltip - Hover behavior (light mode)

Hovering over bars correctly displays the tooltip with role name, average time (in minutes), and total number of applications. Tested across multiple bars, each tooltip correctly reflects the data for that specific role.

Image

Role filter

Selecting a specific role from the Role dropdown correctly filters the chart to show only that role, and the tooltip data remains accurate.

Image

Date filter - data unchanged after filter change

After changing the Dates dropdown (e.g. from ALL to Last 7 Days), the chart data did not change. This may be a pre-existing data issue unrelated to this PR rather than a regression introduced here - the tooltip itself continues to display correctly for whatever data is shown.


Light mode

Chart renders cleanly in light mode. Title, bars, axis labels, and summary text all display correctly with good contrast.


Dark mode

Toggled dark mode. Chart title, bars, axis labels, and summary text all adapt correctly. No contrast issues or broken styles. Tooltip also displays correctly in dark mode with readable text and appropriate background contrast.

Image

@handikaharianto handikaharianto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alishawalunj , after reviewing your PR, the tooltip has been implemented correctly and includes the necessary information, such as role name, average time, and total number of applications. And it also works properly in both dark/light modes.

Image Image Image

YSWFelicity
YSWFelicity previously approved these changes Jun 14, 2026

@YSWFelicity YSWFelicity left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested — Working as expected
Followed the test steps on the PR branch (alisha/fix/application-time-chart-tooltip-data-clarity):

✅ Checked out the PR branch
✅ Ran npm install and started the dev server (npm start)
✅ Cleared site data/cache and logged in as an admin user
✅ Navigated to http://localhost:5173/application-time-chart
Tooltip verification
Hovering over each bar in the chart correctly displays a tooltip with all three required fields:

Role name (e.g. the role label of the hovered bar)
Avg. Time in minutes
Applications (total number of applications)
The tooltip follows the cursor smoothly and stays within the viewport (doesn't get clipped at the chart edges). Values update correctly when switching the Dates and Role filters.

Theme verification
☀️ Light mode (white): tooltip text, divider, and background render clearly with good contrast. ✅
🌙 Dark mode (black): toggled dark mode — tooltip and chart styling adapt correctly, text remains readable, no contrast issues. ✅
Result: Tested in both light and dark mode — passed. 👍

Image Image

@AmaanSyed09 AmaanSyed09 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I tested the PR locally and verified the following:

  1. Tooltip displays the required information: role name, average time in minutes, and total number of applications.

  2. Tooltip formatting is clear and readable in both light mode and dark mode.

  3. Role filtering works correctly and updates the chart as expected.

  4. The page renders correctly in both light mode and dark mode.

Issues Found:

  1. The Date filter does not appear to affect the displayed data. I tested multiple date ranges, including Last 7 Days and Last 30 Days, and the chart values, summary statistics, and tooltip data remained unchanged.

  2. The PR description states that tooltip data should update dynamically when Date or Role filters are changed. Role filtering works correctly, but I was unable to verify the expected behavior for Date filtering.

  3. I also noticed existing code review concerns around unstable keys from uuidv4(), tooltip fade-out behavior, unused hideTimerRef logic, and the totalApplications fallback using || 1 instead of preserving 0 values.

Requesting changes so the Date filter behavior and related tooltip/chart update logic can be fixed or clarified before approval.

Screenshots:

Image Image Image

The Date filter doesn't update.

Image Image

Dnagabahiru
Dnagabahiru previously approved these changes Jun 20, 2026

@Dnagabahiru Dnagabahiru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything is working properly.

The tooltip displays correctly on hover in the Application Time Chart, showing the role name, average time in minutes, and total number of applications. Site data/cache was cleared and verified after logging in as an admin user.

Image Image

@pixelpix13 pixelpix13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alishawalunj, I tested this pr and below are my reviews

Visual Testing

  • Tooltip appears on bar hover showing role name, avg time, and application count
  • Tooltip repositions correctly near viewport edges
  • Filters (Dates + Role) update tooltip data dynamically
  • Light mode rendering correct
  • Dark mode rendering correct

Code Issues Found

  1. uuidv4() used as map key (lines ~285, ~324) — generates new keys on every render,
    causing unnecessary remounts. Should use item.role as a stable key.
  2. Tooltip fade-out doesn't animate — element is removed immediately from DOM when
    visible=false, bypassing the CSS transition. Tooltip should always be rendered and
    only the tooltipVisible class should be toggled.
  3. hideTimerRef is never assignedclearTimeout is called on it but no
    setTimeout is ever set. Dead code.
  4. count: item.totalApplications || 1 — fallback should be ?? 0, not || 1,
    to correctly show 0 applications instead of 1.

Light Mode
image

Dark Mode
image

@handikaharianto handikaharianto changed the title Alisha - fix(job-analytics): improve tooltip data clarity for application time… Handika taking over for Alisha - fix(job-analytics): improve tooltip data clarity for application time… Jun 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.