Skip to content

Alisha - fix(job-analytics): improve tooltip data clarity for application time…#5043

Open
alishawalunj wants to merge 3 commits intodevelopmentfrom
alisha/fix/application-time-chart-tooltip-data-clarity
Open

Alisha - fix(job-analytics): improve tooltip data clarity for application time…#5043
alishawalunj wants to merge 3 commits intodevelopmentfrom
alisha/fix/application-time-chart-tooltip-data-clarity

Conversation

@alishawalunj
Copy link
Copy Markdown
Contributor

Description

F77442B5-839A-4A04-A668-E54C4B285696

Related PRS (if any):

To test this frontend PR you need to checkout development branch for backend.

Main changes explained:

  • Update ApplicationTimeChart.jsx for adding tooltip on bar hover displaying role name, average time, and total applications with dynamic filter support
  • Update ApplicationTimeChart.module.css for introducing tooltip styles

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/application-time-chart
  6. verify the tooltip is displayed on hovering over the chart displaying role name, average time (in minutes), and total number of applications

Screenshots or videos of changes:

22CFEE5E-CCD7-4EF4-8EF1-48D4A62E51CF

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 22, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 55e19d7
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69dc58823ac01600081c926e
😎 Deploy Preview https://deploy-preview-5043--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@one-community one-community changed the title fix(job-analytics): improve tooltip data clarity for application time… Alisha - fix(job-analytics): improve tooltip data clarity for application time… Apr 6, 2026
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 6, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I have reviewed your PR locally. The tooltip improvements are working as expected, showing the role name, average time, and total applications correctly.

One observation: the chart title color is not adapting to dark mode.

Image Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

I have reviewed your PR locally and not sure why the dark mode is not working in your PR since it seems to work in Dev, could you pull the latest changes and make sure the toggle is well adapted to dark mode as black background would ideally not work well.

localhost
light mode
Screenshot 2026-04-08 at 9 39 50 PM
dark mode
Screenshot 2026-04-08 at 9 39 56 PM

dev dark mode
Screenshot 2026-04-08 at 9 39 59 PM

rajanidi1999
rajanidi1999 previously approved these changes Apr 12, 2026
Copy link
Copy Markdown

@rajanidi1999 rajanidi1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall,
Just one accessibility suggestion: the .bar div is interactive (hover/tooltip), so it should ideally support keyboard access (e.g., tabIndex, role="button", and focus/blur handlers).
Also noticed a few duplicate CSS properties that could be cleaned up.
Otherwise, great work on the tooltip behavior and positioning

image

@alishawalunj alishawalunj force-pushed the alisha/fix/application-time-chart-tooltip-data-clarity branch from 062381f to 4cb7b27 Compare April 13, 2026 02:33
@alishawalunj
Copy link
Copy Markdown
Contributor Author

Hi Alisha,

I have reviewed your PR locally and not sure why the dark mode is not working in your PR since it seems to work in Dev, could you pull the latest changes and make sure the toggle is well adapted to dark mode as black background would ideally not work well.

localhost light mode Screenshot 2026-04-08 at 9 39 50 PM dark mode Screenshot 2026-04-08 at 9 39 56 PM

dev dark mode Screenshot 2026-04-08 at 9 39 59 PM

The issue is fixed. Please review.

Image 4-12-26 at 10 41 PM

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@rajanidi1999 rajanidi1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,

Thanks for fixing the issues. The toggle is now well adapted in both the modes.

Image Image

Copy link
Copy Markdown

@rithika-paii rithika-paii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alisha,
I reviewed the PR #5043 locally, and it works well! No changes required from my side!

PR.5043.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants