Amalesh - Taking Over 'Create Refresh Button for Disconnected Timer'#5140
Open
Amalesh-A wants to merge 1 commit intodevelopmentfrom
Open
Amalesh - Taking Over 'Create Refresh Button for Disconnected Timer'#5140Amalesh-A wants to merge 1 commit intodevelopmentfrom
Amalesh-A wants to merge 1 commit intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Amalesh-A
added
the
High Priority - Please Review First
Reviewed this refresh button, no issues
well done
|
rapolusidhartha
approved these changes
Apr 18, 2026
rapolusidhartha
left a comment
rapolusidhartha
left a comment
There was a problem hiding this comment.
Working as expected, well done
Rajasrivatsansrinivasan
approved these changes
Apr 18, 2026
Rajasrivatsansrinivasan
left a comment
Rajasrivatsansrinivasan
left a comment
There was a problem hiding this comment.
Reviewed PR #5140 by Amalesh. Checked out the branch locally and tested the timer disconnection flow by turning the backend off and back on. Verified that the timer correctly enters a disconnected state when the backend is unavailable, and that after restarting the backend, the new reload button restores the timer to a normal connected state as expected. No issues were observed during testing. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PRS (if any):
This frontend PR is related to the development branch of the backend.
Main changes explained:
How to test:
Screenshots or videos of changes:
Screenshots:
Screen-recording
refresh-button-progress.mp4
Note:
Include the information the reviewers need to know.