Anthony/feature-reorder-warning-trackers#5146
Open
AnthonyWeathers wants to merge 1 commit intodevelopmentfrom
Open
Anthony/feature-reorder-warning-trackers#5146AnthonyWeathers wants to merge 1 commit intodevelopmentfrom
AnthonyWeathers wants to merge 1 commit intodevelopmentfrom
Conversation
… list not displaying updated name for trackers when renamed through tracker modal
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: added ability to reorder warning trackers, and fixed warning list not displaying updated name for trackers when renamed through tracker modal
Description
Added ability to reorder the warning trackers through the modal, also fixed issue where renaming a tracker wasn't being properly reflected in the warning list for a user after clicking 'Tracking'.
Related PRS (if any):
This frontend PR is related to the PR#2167 backend PR.
…
Main changes explained:
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Demo (Also shows edge cases I noted below except for one)
Note:
When viewing the modal opened by +/-, you can not rename a warning tracker, and reorder the list of trackers and save both changes. It will prioritize the renaming and not do the reordering. I did not look into trying to allow multiple changes to be saved, so this is just to let you know to do only one change at a time before saving.
Also, very fringe edge case, if you click 'Tracking' for multiple users, opening their individual list of warnings, then click the +/- to open the modal, and make a change, it will reflect properly in the user's list that you opened the modal from, but not the others. This is due to me having made it return the changes for the specific user only. Not all users in general, so to verify if the other lists are updated properly, you'd need to click the 'Hide' button, to hide the lists and change it to 'Tracking', then reopen their lists, and the warning lists for those users should be reflecting the updated version.
If you rename a tracker, and have kept the list of a separate user open, then added a warning to the outdated version of the tracker, it'll get the new name, but lost the new warning. To retrieve the missing warning, you'd need to rename the tracker back to how it was, get the new warning to appear, then rename it again, and it should have all of the warnings plus the new one.
Last note: On the backend, I made it so one of the functions that'd update old warnings (primarily ones made outside of this PR), only target my accounts, containing 'Anthony', I'll change it before the merge, I limited its scope to avoid updating all warnings without more testing first.