Linh - fix: resolve PR 4246 issues in listing and bidding dashboard#5165
Open
linh2020 wants to merge 2 commits intodevelopmentfrom
Open
Linh - fix: resolve PR 4246 issues in listing and bidding dashboard#5165linh2020 wants to merge 2 commits intodevelopmentfrom
linh2020 wants to merge 2 commits intodevelopmentfrom
Conversation
- fix logged-hours dropdown filtering for pie chart updates - improve pie chart label visibility and light-mode readability - remove duplicate rubric modal rendering that required two close clicks
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Rajasrivatsansrinivasan
approved these changes
Apr 18, 2026
Rajasrivatsansrinivasan
left a comment
There was a problem hiding this comment.
Reviewed PR #5165 by Linh. Checked out the branch locally and tested the Listing and Bidding Dashboard updates along with the related student task flow. Verified that chart text is readable in light mode, pie chart labels are more visible and less likely to be cut off, the logged-hours dropdown updates the pie chart correctly including the 0-hours case, and the View Grading Rubric modal now closes properly on the first click. No issues were observed during testing. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes the reported UI and interaction bugs from PR 4246 for the Listing and Bidding Dashboard work in progress. This update addresses chart readability issues, light-mode text visibility, the grading rubric modal close behavior, and the dropdown filter behavior that was not updating the pie chart correctly.
Result:
Users can now view chart text more clearly and interact with the dashboard without the reported blockers:
Related PRs (if any): #4246
Main changes explained:
How to test:
Check into the current branch.
Run the frontend locally:
npm installClear site data/cache.
Log in as an authorized user.
Go to the relevant dashboard/student task views used in PR 4246.
Verify light mode behavior:
Verify pie chart label behavior:
Verify dropdown filtering:
0hours case updates correctly.Verify grading rubric modal:
View Grading Rubric.Xicon.Notes: