Sai Sandeep - Fix Warnings in PeopleTableDetails Unit Tests #3467#5170
Open
saisandeepkoritala wants to merge 1 commit intodevelopmentfrom
Open
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Rajasrivatsansrinivasan
approved these changes
Apr 18, 2026
Rajasrivatsansrinivasan
left a comment
Rajasrivatsansrinivasan
left a comment
There was a problem hiding this comment.
Reviewed PR #5170 by Sai Sandeep. Checked out the branch locally, verified the PeopleTableDetails tests, and confirmed the previous unique key warning is resolved. Also tested the People report flow by selecting a user and checking that task-related details and filtering still behave as expected. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change data structure usage in PeopleTableDetails.jsx to fix warnings from running unit tests.
Previously, running PeopleTableDetails.test.js would generate a warning message: each child in a list should have a unique "key" prop. The warning is not caused by unit tests code, but indexing in PeopleTableDetails.jsx.
Related PRS (if any):
This PR resolves issues in PR #3467
Main changes explained:
Making key prop unique for all loops
### How to test:
check into current branch
do npm install
do npm test PeopleTableDetails.test.js to run the tests
verify that all tests pass without warning messages
### Run this PR locally
Clear site data/cache
log as admin user
go to dashboard→ Reports → People, select an user
verify task filtering works the same as the development branch