Skip to content

Sphurthy clear date filter fix#5208

Open
sphurthy wants to merge 9 commits into
developmentfrom
sphurthy-clear-date-filter-fix
Open

Sphurthy clear date filter fix#5208
sphurthy wants to merge 9 commits into
developmentfrom
sphurthy-clear-date-filter-fix

Conversation

@sphurthy

@sphurthy sphurthy commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Description

image

Related PRS (if any):

None.
…

Main changes explained:

  • Removed the "Clear Date Filter" button, no longer needed; toggling the radio off does the same job.
  • Made Tomorrow / This Weekend radios toggleable, clicking a selected option a second time deselects it and clears the filter. First click selects; second click clears; switching to the other option works as before.
  • Cleaned up sidebar markup, replaced reactstrap FormGroup/Input/Label with plain HTML for the radios, the Online Only checkbox, and the dropdowns. Bootstrap's .form-check styles were fighting the custom CSS and producing the weird radio offsets and overlapping checkbox.
  • Fixed dark-mode regressions uncovered by the cleanup: labels were white-on-white, and the search bar's icon area had a stuck white background.

…

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Navigate to /communityportal.
  5. Toggle behavior:
  6. Click Tomorrow → filter applies, only events for tomorrow show.
  7. Click Tomorrow again → filter clears, all events return.
  8. Click Tomorrow, then This Weekend → switches; only one is ever selected.
  9. Click This Weekend while it's selected → clears.

Screenshots or videos of changes:

image

@netlify

netlify Bot commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 90c2331
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a3b0d0de2bca8000851237a
😎 Deploy Preview https://deploy-preview-5208--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

HemanthNidamanuru
HemanthNidamanuru previously approved these changes May 1, 2026
View reviewed changes

@HemanthNidamanuru HemanthNidamanuru left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I tested all the toggle behaviors including clicking Tomorrow to apply and clear the filter, switching between Tomorrow and This Weekend, and clearing This Weekend while selected. Everything is working as expected

PR.5208.mp4

@sonarqubecloud

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jun 18, 2026
mahathiganimi
mahathiganimi previously approved these changes Jun 20, 2026
View reviewed changes

@mahathiganimi mahathiganimi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, checked this branch locally and tested. The functionality that this PR needs to fix- works perfectly as intended. Please resolve the merge conflicts and we are good to go.

Image

Abhi-R0211
Abhi-R0211 requested changes Jun 21, 2026
View reviewed changes

@Abhi-R0211 Abhi-R0211 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on branch sphurthy-clear-date-filter-fix, and here is my analysis:

What's Working Well

  • "Clear Date Filter" button is removed as expected
  • Tomorrow and This Weekend radios toggle correctly — clicking once applies the filter, clicking again clears it, and switching between the two works as expected
Image
  • Dark mode radio labels are readable and the search bar icon area no longer has a stuck white background
  • Mobile layout (375px) renders cleanly with no radio offset or overflow issues
Image

Issues

  1. Unresolved merge conflicts blocking merge
    The branch has active conflicts. Please resolve the conflicts and this should be good to go.

sphurthy and others added 2 commits June 23, 2026 18:34
@sphurthy @claude
Merge development into sphurthy-clear-date-filter-fix
882a9ce 
Resolve conflicts while retaining this branch's functional event filters
(date toggle with clear-on-re-click, online-only, past-events) which
development's refactor had replaced with a non-functional FiltersSidebar.

- CPDashboard.jsx / .module.css: keep this branch's functional version
  (the CSS module is consumed only by this component)
- yarn.lock: take development's (matches dev package.json; fixes CI
  yarn install --frozen-lockfile)
- package-lock.json: drop (development removed it; repo uses yarn)

Fix: remove duplicate <select> placeholders that sat next to the real
<Input type="select"> for Branches/Themes/Categories (duplicate DOM ids
and dead UI left over from an earlier botched merge).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sphurthy
resolved merge conflicts
90c2331
@sonarqubecloud

sonarqubecloud Bot commented Jun 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abhi-R0211 Abhi-R0211 Abhi-R0211 requested changes

@HemanthNidamanuru HemanthNidamanuru HemanthNidamanuru left review comments

@mahathiganimi mahathiganimi mahathiganimi left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sphurthy @HemanthNidamanuru @Abhi-R0211 @mahathiganimi @one-community