Vinay K Costs Graph#5276
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Hi Vinay,
Tested Financials Tracking → Planned vs Actual Costs for budget indicators and variance.
Currently blocked by an API issue — the page shows:
“Error: Failed to load project cost data”
From the logs, the predictions API request appears to be malformed due to URL construction:
http://localhost:4500/api//project/1/predictions
(double / before project).
It looks like APIEndpoint already includes /api, and the request path may be adding an extra /. Because of this, I’m unable to verify the Planned vs Actual Cost calculations/variance until the API issue is resolved
…fix vitest peer dep
…ent to reduce cognitive complexity
|
DeepighaJ
left a comment
There was a problem hiding this comment.
- Checked out to current branch and test PR locally.
- The variance and budget indicators are displayed as expected in both light and dark modes.
- However when filtering the categories the Variance & budget indicator displays Total Variance instead of filtered category variance. If this is the expected behavior then good to go.
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Vinay,
I tested this locally following the steps provided and found 1 issue:
The graph is not loading in the Financials Tracking > Planned vs Actual Costs section.
I can see from the backend logs that the API is being called with the Project ID but "No tools found for project" and Total tools cost: 0, which seems to be causing the graph to not render.
amaresh2001
left a comment
There was a problem hiding this comment.
Tested locally on vinay_k_costs_graph.
Testing:
- Variance and Budget Indicators section displays correctly, showing Total Variance, Planned/Actual/Variance breakdown, and "OVER BUDGET" and "UNDER BUDGET" labels.
- Project dropdown updates the bar chart and variance indicators correctly.
- Category dropdown (Overall, Labor, Materials, Equipment) updates the numbers correctly.
- Dark mode is fully supported, variance table and indicators remain readable.
Issues:
"Planned Vs Actual Costs Tracking" line chart fails to load. The left side of the section displays "Error: Failed to load project cost data" instead of rendering the line chart (with Planned Cost, Actual Cost, and Predicted Cost lines).
mahathiganimi
left a comment
There was a problem hiding this comment.
Hi Vinay,
I have tested this branch locally. The Variance and Budget Indicators section displays correctly, showing Total Variance, Planned/Actual/Variance breakdown, and "OVER BUDGET"/"UNDER BUDGET" labels as expected. The Project dropdown updates the bar chart and variance indicators correctly, and the Category dropdown (Overall, Labor, Materials, Equipment) updates the numbers correctly too. Dark mode is fully supported everything is readable.
However, I found an issue with the "Project cost data" line chart, it fails to load. Instead of rendering the line chart, the right side of the section shows "Error: Failed to load project cost data". Requesting changes to fix this before approval
|
Abhi-R0211
left a comment
There was a problem hiding this comment.
I tested locally on branch vinay_k_costs_graph, logged in as admin, and here is my analysis:
What's Working Well
- Variance and Budget Indicators panel renders correctly in both light and dark mode — Total Variance badge, Planned/Actual/Variance breakdown, and OVER/UNDER BUDGET label all display as expected
- Bar chart (Actual vs Planned) updates correctly when switching projects and categories
- Dark mode styling on the variance panel is readable with appropriate contrast
- Mobile layout (375px) stacks acceptably and dropdowns remain functional
Issues
- Line chart still failing to load across all modes
The "Planned Vs Actual Costs Tracking" line chart continues to show "Error: Failed to load project cost data" in light mode, dark mode, and at 375px mobile width. The latest commit message states "Line chart is working as expected" but the error persists on the current branch







Description
Related PRS (if any):
This frontend PR is related to the development backend PR.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Task.mov
Note:
Include the information the reviewers need to know.