Sphurthy - implemented 🔥 fix for timeoff status#5317
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DeepighaJ
left a comment
There was a problem hiding this comment.
- A video of the change would be great to understand this and test.
- Dark mode need improvement.
- I can find Sayantan_DevAdmin as only user available to assign taks in resources. Since logging in as test user required to validate, Can you pls confirm if my test admin id need to be assigned to task and request time should be validated for the same user right ?
- After navigating to User Management request time off is not clickable.
mahathiganimi
left a comment
There was a problem hiding this comment.
Hi, I have tested this branch in my local. I have not been able to fully test the functionalities. A testing video would be really helpful, as navigating as per the instructions mentioned was not smooth. However I found couple of issues before I encountered a bottle neck at user management page. The palette in the dark mode is not readable ( View the screenshot attached).
Once I move to user management to schedule a time off for the user, the request time off triggers nothing on the screen. The page becomes unresponsive. Hence was not able to validate next few actions. Requesting you to check for it.
|




Description
Fixes issue with tasks reviewed button not working/accessible when people have requested time off and some coloring issues for the same. Here's a video from Jae: https://www.loom.com/share/86f58e5b27a3496e998d82ed9f2b89e7
Related PRS (if any):
None
Main changes explained:
How to test:
Screenshots or videos of changes:
Case.A.mp4
Case.B.mp4