Add daily GSIFI governance artifacts, validation tools, tests, and CI workflow#106
Merged
OneFineStarstuff merged 3 commits intoJun 1, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review changes with Changed Files
|
|
The files' contents are under analysis for test generation. |
|
Review these changes at https://app.gitnotebooks.com/OneFineStarstuff/OneFineStarstuff.github.io/pull/106 |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @OneFineStarstuff, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
View changes in DiffLens |
Contributor
📝 WalkthroughWalkthroughThis PR establishes a complete daily G-SIFI governance framework comprising canonical JSON/Rego artifacts, Python validation and orchestration tools, comprehensive test coverage, and CI/CD integration to continuously enforce governance compliance and model risk posture validation. ChangesDaily G-SIFI Governance Framework
Sequence Diagram(s)sequenceDiagram
participant GHA as GitHub Actions
participant Checkout as Repo Checkout
participant Py as Python Setup
participant Make as Makefile
participant Validate as Validator Tool
participant Pytest as Pytest Suite
participant Report as Report Generator
participant Summary as GITHUB_STEP_SUMMARY
participant Artifacts as Artifacts Upload
GHA->>Checkout: Check out repository
GHA->>Py: Set up Python 3.12
GHA->>Make: make daily-gsifi-governance-pycompile
Make->>Py: Compile governance tool scripts
GHA->>Make: make daily-gsifi-governance-ci
Make->>Validate: Validate artifact synchronization
Validate-->>Make: Return (0 if all pass)
Make->>Pytest: Run governance test suite
Pytest-->>Make: Return (0 if all pass)
Make->>Make: Write JUnit XML + JSON summary
GHA->>Report: make daily-gsifi-governance-report
Report->>Report: Format JSON summary into Markdown table
GHA->>Summary: cat report.md >> GITHUB_STEP_SUMMARY
GHA->>Artifacts: Upload test results (XML, JSON, Markdown)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Failed to generate code suggestions for PR |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 38 high |
| Security | 1 minor 55 high 1 critical 1 medium |
| CodeStyle | 2 minor |
| Complexity | 1 critical 1 minor |
🟢 Metrics 60 complexity · 0 duplication
Metric Results Complexity 60 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
for more information, see https://pre-commit.ci
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5a4acee14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
View changes in DiffLens |
❌ Deploy Preview for onefinestarstuff failed.
|
…mework Signed-off-by: 𝐎𝐧𝐞 𝐅𝐢𝐧𝐞 𝐒𝐭𝐚𝐫𝐬𝐭𝐮𝐟𝐟 <onefinestarstuff@gmail.com>
|
View changes in DiffLens |
|
View changes in DiffLens |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
Makefile (1)
175-187: ⚡ Quick win
daily-gsifi-governance-evidenceduplicatesdaily-gsifi-governance-ci.Both targets run identical
mkdir+run_gsifi_governance_checks.pycommands with the same artifact paths. Collapse one into the other to avoid silent divergence.♻️ Proposed refactor
-daily-gsifi-governance-evidence: - mkdir -p artifacts/test-results - python tools/run_gsifi_governance_checks.py --junitxml=artifacts/test-results/gsifi-governance-tests.xml --emit-json=artifacts/test-results/gsifi-governance-run-summary.json +daily-gsifi-governance-evidence: daily-gsifi-governance-ci🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Makefile` around lines 175 - 187, The Makefile has duplicate targets daily-gsifi-governance-ci and daily-gsifi-governance-evidence that run the same mkdir + python command; remove the duplicated command block and make one target depend on the other (for example keep daily-gsifi-governance-ci with the mkdir/python commands and change daily-gsifi-governance-evidence to be a one-line dependency: daily-gsifi-governance-evidence: daily-gsifi-governance-ci) so both names work without code duplication.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/daily-gsifi-governance-validation.yml:
- Around line 71-76: The "Generate governance markdown summary" step (run: make
daily-gsifi-governance-report) is skipped on failure which causes the downstream
"Append governance summary to job summary" step to cat a missing file; add if:
always() to the "Generate governance markdown summary" step so the report is
created even when earlier steps fail, ensuring
artifacts/test-results/gsifi-governance-run-summary.md exists before the "Append
governance summary to job summary" step runs.
In `@artifacts/daily_governance_report.schema.json`:
- Around line 17-19: The schema currently allows malformed values; update
field-level constraints to enforce semantics: change "report_date" to require an
ISO-8601 timestamp (use JSON Schema "format": "date-time" or a strict regex),
tighten numeric fields to integer type with "minimum": 0 for all count-like
properties, constrain arrays with "minItems" and proper "items" schemas (no
free-form arrays), and add enums or pattern constraints where applicable for
status/value fields; apply the same hardening to the fields referenced in the
other ranges (lines 31-39, 79-84, 94-99, 135-137) so invalid governance reports
fail validation early.
- Around line 4-5: The schema currently allows undeclared fields; add
"additionalProperties": false to the root object (alongside "type": "object" and
"required") to enforce closed-world validation, and also add
"additionalProperties": false to every nested object schema (any property
definitions or sub-schemas inside the document) so misspelled/rogue keys are
rejected; update the root schema and each object-like schema (e.g., any entries
under "properties" or definitions) to include this keyword.
In `@DAILY_GSIFI_AGI_ASI_GOVERNANCE_2026_2030.md`:
- Around line 232-233: The heading "11.1 Daily governance report schema (JSON)"
is incorrect for the fenced content (which is an example report instance);
update the heading text (the "11.1" heading) to reflect that the block is an
example, e.g., rename to "11.1 Daily governance report example (JSON)" or "11.1
Example daily governance report (JSON)" so the heading matches the JSON content
and avoids operator confusion; locate the heading string "Daily governance
report schema (JSON)" and replace it accordingly.
In `@GOVERNANCE_ARTIFACTS_README.md`:
- Around line 28-33: The README uses two different Make target names
(`daily-gsifi-governance-checks` and `daily-gsifi-governance-ci`) causing
confusion; pick the canonical target name (prefer `daily-gsifi-governance-ci`)
and update every occurrence (including the instances around lines with the code
block and the section referenced at 62-64) so all examples and CI documentation
use the same target, or explicitly add a note that one is an alias and document
the alias mapping; ensure the README text and all code blocks consistently
reference the chosen Make target string.
In `@test_governance_snippets.py`:
- Around line 124-127: The test currently only uses datetime.fromisoformat on
example['approvals']['timestamp_utc'] (ts) which is permissive; add a strict
RFC3339 UTC regex check first to enforce canonical Z-suffixed UTC format (e.g.
YYYY-MM-DDTHH:MM:SS[.fraction]Z) and assert the regex matches ts before calling
datetime.fromisoformat(ts.replace('Z','+00:00')) so malformed or non-canonical
forms are rejected; reference the timestamp_utc/ts variable and the existing
parsing line when inserting the regex assertion.
---
Nitpick comments:
In `@Makefile`:
- Around line 175-187: The Makefile has duplicate targets
daily-gsifi-governance-ci and daily-gsifi-governance-evidence that run the same
mkdir + python command; remove the duplicated command block and make one target
depend on the other (for example keep daily-gsifi-governance-ci with the
mkdir/python commands and change daily-gsifi-governance-evidence to be a
one-line dependency: daily-gsifi-governance-evidence: daily-gsifi-governance-ci)
so both names work without code duplication.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e1338033-a076-4e8d-b5a4-de5c85d64141
📒 Files selected for processing (16)
.github/workflows/daily-gsifi-governance-validation.ymlDAILY_GSIFI_AGI_ASI_GOVERNANCE_2026_2030.mdGOVERNANCE_ARTIFACTS_README.mdMakefileartifacts/daily_governance_report.example.jsonartifacts/daily_governance_report.schema.jsonpolicies/sentinel_governance.regorequirements-governance-checks.txttest_daily_gsifi_governance_workflow.pytest_generate_gsifi_governance_report.pytest_governance_snippets.pytest_run_gsifi_governance_checks.pytest_validate_governance_artifacts.pytools/generate_gsifi_governance_report.pytools/run_gsifi_governance_checks.pytools/validate_governance_artifacts.py
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DAILY_GSIFI_AGI_ASI_GOVERNANCE_2026_2030.mdwith fenced canonicaljsonandregosnippets and operational runbook content.artifacts/daily_governance_report.example.jsonandartifacts/daily_governance_report.schema.jsonand policy sketchpolicies/sentinel_governance.rego.tools/validate_governance_artifacts.py,tools/run_gsifi_governance_checks.py, andtools/generate_gsifi_governance_report.pyplus a minimalrequirements-governance-checks.txt.Makefilewith daily targets, addGOVERNANCE_ARTIFACTS_README.md, and add a GitHub Actions workflow.github/workflows/daily-gsifi-governance-validation.ymlto run validations and upload JUnit/JSON artifacts.Testing
make daily-gsifi-governance-pycompile, which compiles the validator/generator/runner and test modules and succeeded.make daily-gsifi-governance-ci, which runstools/run_gsifi_governance_checks.pyand emits JUnit and JSON summaries, and it completed successfully.pytestfor the new teststest_governance_snippets.py,test_validate_governance_artifacts.py,test_run_gsifi_governance_checks.py,test_generate_gsifi_governance_report.py, andtest_daily_gsifi_governance_workflow.py, and all tests passed.tools/generate_gsifi_governance_report.pytests which produced the expected markdown output.Codex Task
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores