Skip to content

fix(core): reduce accessList size to 8 due to memory limits #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somebodyLi merged 1 commit into from
Sep 8, 2025
Merged

fix(core): reduce accessList size to 8 due to memory limits #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion legacy/firmware/ethereum.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ static bool eip1559;
struct SHA3_CTX keccak_ctx = {0};

static uint32_t signing_access_list_count;
static EthereumAccessList signing_access_list[16];
static EthereumAccessList signing_access_list[8];
_Static_assert(sizeof(signing_access_list) ==
sizeof(((EthereumSignTxEIP1559 *)NULL)->access_list),
"access_list buffer size mismatch");
Expand Down
2 changes: 1 addition & 1 deletion legacy/firmware/ethereum_onekey.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static bool eip1559;
static struct SHA3_CTX keccak_ctx = {0};

static uint32_t signing_access_list_count;
static EthereumAccessListOneKey signing_access_list[16];
static EthereumAccessListOneKey signing_access_list[8];
_Static_assert(sizeof(signing_access_list) ==
sizeof(((EthereumSignTxEIP1559OneKey *)NULL)->access_list),
"access_list buffer size mismatch");
Expand Down
2 changes: 1 addition & 1 deletion legacy/firmware/protob/messages-ethereum-onekey.options
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ EthereumSignTxEIP1559OneKey.gas_limit max_size:32
EthereumSignTxEIP1559OneKey.to max_size:43
EthereumSignTxEIP1559OneKey.value max_size:32
EthereumSignTxEIP1559OneKey.data_initial_chunk max_size:1024
EthereumSignTxEIP1559OneKey.access_list max_count:16
EthereumSignTxEIP1559OneKey.access_list max_count:8

EthereumAccessListOneKey.address max_size:43
EthereumAccessListOneKey.storage_keys max_count:8 max_size:32
Expand Down
2 changes: 1 addition & 1 deletion legacy/firmware/protob/messages-ethereum.options
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ EthereumSignTxEIP1559.gas_limit max_size:32
EthereumSignTxEIP1559.to max_size:43
EthereumSignTxEIP1559.value max_size:32
EthereumSignTxEIP1559.data_initial_chunk max_size:1024
EthereumSignTxEIP1559.access_list max_count:16
EthereumSignTxEIP1559.access_list max_count:8

EthereumAccessList.address max_size:43
EthereumAccessList.storage_keys max_count:8 max_size:32
Expand Down
Loading