Skip to content

chore(ci): remove legacy S3 CDN deploy from release-web#744

Merged
wabicai merged 3 commits intoonekeyfrom
chore/remove-release-web-cdn
Apr 9, 2026
Merged

chore(ci): remove legacy S3 CDN deploy from release-web#744
wabicai merged 3 commits intoonekeyfrom
chore/remove-release-web-cdn

Conversation

@wabicai
Copy link
Copy Markdown
Member

@wabicai wabicai commented Apr 9, 2026

Summary

  • remove legacy CDN deploy step from release-web workflow
  • remove AWS secret inputs (AWS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_BUCKET) and CDN path envs
  • keep build and artifact upload so manual workflow still produces downloadable artifacts

Test plan

  • Trigger deploy-release-iframe-web workflow manually
  • Confirm build step succeeds
  • Confirm no AWS/CDN deploy step appears
  • Confirm artifact upload succeeds and build output is downloadable

Made with Cursor

The release-web workflow no longer uploads build output to CDN and no longer depends on AWS secrets. Keep artifact upload only to match the current release process.

Made-with: Cursor
@revan-zhang
Copy link
Copy Markdown
Contributor

revan-zhang commented Apr 9, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Comment thread .github/workflows/release-web.yml
Keep PUBLIC_PATH injection in release-web workflow while removing legacy CDN upload and AWS secrets usage.

Made-with: Cursor
@wabicai wabicai requested a review from originalix April 9, 2026 08:45
@wabicai wabicai enabled auto-merge (squash) April 9, 2026 08:46
Comment thread .github/workflows/release-web.yml
Keep PUBLIC_PATH at job level and also pass it explicitly to the build step for clarity after removing duplicate build/deploy flow.

Made-with: Cursor
@wabicai wabicai requested a review from originalix April 9, 2026 08:54
@wabicai wabicai merged commit c2bcefb into onekey Apr 9, 2026
10 checks passed
@wabicai wabicai deleted the chore/remove-release-web-cdn branch April 9, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants