Skip to content

fix(deps): upgrade axios to 1.15.2#776

Merged
wabicai merged 4 commits into
onekeyfrom
codex/upgrade-axios-1-15-2
Apr 28, 2026
Merged

fix(deps): upgrade axios to 1.15.2#776
wabicai merged 4 commits into
onekeyfrom
codex/upgrade-axios-1-15-2

Conversation

@wabicai
Copy link
Copy Markdown
Member

@wabicai wabicai commented Apr 27, 2026

Summary

  • upgrade direct axios dependencies from 1.15.0 to 1.15.2 in OneKey packages
  • remove Ledger-specific axios resolutions and leave @ledgerhq/context-module / @ledgerhq/device-management-kit transitive axios unchanged for now
  • refresh standalone example lockfiles so axios resolves to 1.15.2 without upgrading unrelated SDK packages
  • keep native Android/iOS WebView examples on @onekeyfe/hd-common-connect-sdk@1.1.15 and use only axios resolutions there
  • keep react-native-demo SDK dependencies on the original @onekeyfe/hd-ble-sdk / @onekeyfe/hd-core 1.1.16 and use only axios resolution there
  • normalize newly changed lockfile resolved URLs to registry.yarnpkg.com where yarn refreshed entries
  • rebuild native Android/iOS embedded WebView assets from the stable SDK + axios resolution output
  • fix lint errors reported by the PR lint job and add the missing hd-cli Jest preset wrapper so its TS tests run in CI

Verification

  • yarn install
  • yarn install --frozen-lockfile
  • yarn install --frozen-lockfile in packages/connect-examples/native-android-example/web
  • yarn install --frozen-lockfile in packages/connect-examples/native-ios-example/web
  • yarn install --frozen-lockfile in packages/connect-examples/react-native-demo
  • yarn why axios
  • yarn build
  • yarn build in packages/connect-examples/native-android-example/web
  • yarn build in packages/connect-examples/native-ios-example/web
  • NODE_OPTIONS=--max-old-space-size=8192 yarn lint --quiet
  • yarn --cwd packages/hd-cli test
  • yarn --cwd packages/hwk-adapter-core test
  • yarn lerna run test --scope @onekeyfe/hardware-cli --scope @onekeyfe/hwk-adapter-core
  • yarn lerna run build --scope @onekeyfe/hd-common-connect-sdk --include-dependencies
  • yarn lerna run build --scope @onekeyfe/hd-core --scope @onekeyfe/hd-transport-http --scope @onekeyfe/hd-transport-emulator --include-dependencies
  • yarn lerna run test --scope @onekeyfe/hd-core --scope @onekeyfe/hd-transport-http --scope @onekeyfe/hd-transport-emulator --include-dependencies
  • rg confirms WebView locks/assets do not contain NodeUsbTransport, @onekeyfe/hd-transport-usb, usb@^2.14.0, or node-gyp-build@^4.5.0
  • rg confirms native WebView locks keep @onekeyfe/hd-common-connect-sdk@1.1.15 while resolving axios to 1.15.2
  • rg confirms react-native-demo lock keeps @onekeyfe/hd-ble-sdk / @onekeyfe/hd-core at 1.1.16 while resolving axios to 1.15.2
  • rg confirms this PR no longer adds registry.npmjs.org resolved URLs in changed lockfile entries
  • git diff --check

Note: Git reported the local .husky/pre-commit hook is not executable, so it was ignored during commit.

@revan-zhang
Copy link
Copy Markdown
Contributor

revan-zhang commented Apr 27, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 27, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @react-native/debugger-frontend is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: ?npm/expo@54.0.20npm/@react-native/debugger-frontend@0.81.5

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@react-native/debugger-frontend@0.81.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@wabicai wabicai force-pushed the codex/upgrade-axios-1-15-2 branch 5 times, most recently from 5004fda to 0e44060 Compare April 27, 2026 11:46
@wabicai wabicai force-pushed the codex/upgrade-axios-1-15-2 branch from 0e44060 to 2129eb8 Compare April 27, 2026 11:57
@wabicai wabicai enabled auto-merge (squash) April 27, 2026 12:05
@wabicai wabicai force-pushed the codex/upgrade-axios-1-15-2 branch from a677a77 to c181e4a Compare April 27, 2026 12:19
Comment thread packages/connect-examples/native-android-example/web/package.json Outdated
@wabicai wabicai requested a review from originalix April 28, 2026 04:08
@wabicai wabicai merged commit 7b8e0ff into onekey Apr 28, 2026
10 checks passed
@wabicai wabicai deleted the codex/upgrade-axios-1-15-2 branch April 28, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants