Skip to content

chore: improve item handling#68

Merged
theEvilReaper merged 5 commits intomasterfrom
feature/itemHandling
May 2, 2026
Merged

chore: improve item handling#68
theEvilReaper merged 5 commits intomasterfrom
feature/itemHandling

Conversation

@theEvilReaper
Copy link
Copy Markdown
Collaborator

Proposed changes

Both the game and setup code contain classes that handle item references for different use cases. In the current approach, these classes need to be instantiated. While this works, their nature is closer to that of utility classes. This pull request refactors them into utility classes using static methods, removing the need for instantiation.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@theEvilReaper theEvilReaper self-assigned this May 2, 2026
@theEvilReaper theEvilReaper merged commit 39b81c0 into master May 2, 2026
5 checks passed
@theEvilReaper theEvilReaper deleted the feature/itemHandling branch May 2, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant