Skip to content

Improve useability of the TestConnection#8

Merged
theEvilReaper merged 3 commits into
masterfrom
feature/connectionUpdate
May 23, 2025
Merged

Improve useability of the TestConnection#8
theEvilReaper merged 3 commits into
masterfrom
feature/connectionUpdate

Conversation

@theEvilReaper
Copy link
Copy Markdown
Contributor

Proposed changes

This pull request improves the usability of the TestConnection class by introducing a connect method that doesn't require a position parameter. Instead, it uses a default position, which is useful in scenarios where a player is involved and a specific in-instance position isn't necessary.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper requested a review from TheMeinerLP May 23, 2025 06:37
@theEvilReaper theEvilReaper self-assigned this May 23, 2025
@theEvilReaper theEvilReaper added enhancement New feature or request good first issue Good for newcomers labels May 23, 2025
@theEvilReaper theEvilReaper merged commit 3bfdc3d into master May 23, 2025
7 checks passed
@theEvilReaper theEvilReaper deleted the feature/connectionUpdate branch May 23, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants