Merge pull request #58 from OneLiteFeatherNET/OneLiteFeather/chore/update-dependency-and-fix-command

Update testing and fix issues with commands and translation gathering on startup

Author: OneLiteFeather

build.gradle.kts

@@ -4,7 +4,7 @@ import net.minecrell.pluginyml.paper.PaperPluginDescription
 plugins {
     id("java")
     id("net.minecrell.plugin-yml.paper") version "0.6.0"
-    id("io.github.goooler.shadow") version "8.1.8"
+    id("com.gradleup.shadow").version("9.3.0")
     id("xyz.jpenilla.run-paper") version "3.0.2"
 }
 
@@ -34,7 +34,7 @@ tasks {
     }
 
     runServer {
-        minecraftVersion("1.21.1")
+        minecraftVersion("1.21.10")
         jvmArgs("-Dcom.mojang.eula.agree=true")
     }
 

src/main/java/de/theshadowsdust/ultimatespawn/command/SpawnCommand.java

@@ -38,6 +38,7 @@ public SpawnCommand(@NotNull UltimateSpawnPlugin plugin) {
     public void executeSpawnCommand(Player player, final @Argument(value = "name", suggestions = "spawn_names") @Greedy String name) {
 
         String positionName = name == null ? "spawn" : name;
+        if (positionName.isEmpty()) positionName = "spawn";
 
         try {
             SpawnPosition spawnPosition = this.plugin.getSpawnPositionService().getSpawnPosition(positionName).get();

src/main/java/de/theshadowsdust/ultimatespawn/service/CommandService.java

@@ -35,7 +35,7 @@ public CommandService(@NotNull UltimateSpawnPlugin plugin) {
     public PaperCommandManager<CommandSender> buildCommandSystem() {
         return PaperCommandManager
                 .builder(new BukkitSenderMapper())
-                .executionCoordinator(ExecutionCoordinator.asyncCoordinator())
+                .executionCoordinator(ExecutionCoordinator.simpleCoordinator())
                 .buildOnEnable(this.plugin);
     }
 
@@ -50,7 +50,8 @@ public MinecraftHelp<CommandSender> buildHelpSystem(PaperCommandManager<CommandS
         return MinecraftHelp.<CommandSender>builder()
                 .commandManager(paperCommandManager)
                 .audienceProvider(this.bukkitAudiences::sender)
-                .commandPrefix("/ultimatespawn")
+                // TODO: find out why this clicking and executing command feature has an empty space in chat, might be fault by cloud
+                .commandPrefix("/")
                 .colors(MinecraftHelp.helpColors(
                         NamedTextColor.GOLD,
                         NamedTextColor.GRAY,

src/main/java/de/theshadowsdust/ultimatespawn/service/LanguageService.java

@@ -54,8 +54,7 @@ public Component getMessage(@NotNull String key, Object... placeholders) {
     public void loadMessages() {
         try {
             if (Files.notExists(this.translationDir.toPath())) Files.createDirectory(this.translationDir.toPath());
-            this.defaultMessages = ResourceBundle.getBundle("ultimatespawn_%s".formatted(
-                    this.plugin.getConfigurationService().getConfig().getLanguage()), new UTF8ResourceBundleControl());
+            this.defaultMessages = ResourceBundle.getBundle("ultimatespawn", Locale.forLanguageTag(this.plugin.getConfigurationService().getConfig().getLanguage()), new UTF8ResourceBundleControl());
             this.languageConfiguration = loadLanguageConfig();
         } catch (IOException e) {
             this.plugin.getLogger().log(Level.SEVERE, "Can't load messages", e);

src/main/resources/ultimatespawn_de_DE.properties

@@ -3,7 +3,7 @@ command.reload.success={0} &7Plugin &e{1} &7wurde &aerfolgreich &7neugeladen.
 command.removespawn.success={0} &7Spawn &e{1} &7wurde &aerfolgreich &7entfernt.
 command.setspawn.success={0} &7Spawn &e{1} &7wurde &aerfolgreich &7gesetzt.
 spawn-teleport-success={0} &7Du wurdest &aerfolgreich &7teleportiert!
-spawn-teleport-failure={0} &cDer Teleport ist fehlgeschlagen! Bitte gebe einem Administrator bescheid.
+spawn-teleport-failure={0} &cDer Teleport ist fehlgeschlagen! Bitte gebe einem Administrator Bescheid.
 invalid-world={0} &cUnbekannte Welt!
-spawn-not-exists={0} &cSpawn &c&l{1} &ckonnte nicht gefunden.
+spawn-not-exists={0} &cSpawn &c&l{1} &ckonnte nicht gefunden werden.
 spawn-already-exists={0} &cSpawn &c&l{1} &cexistiert bereits.