Commit f2b5c3a
committed
fix: keep fish clean-mode hooks after the crash fix
The crash fix moved shell-arg synthesis into the wrapper, but that accidentally dropped Taskers fish hooks for clean-profile launches. Clean mode should suppress user config, not Taskers integration. This follow-up keeps the fish hooks sourced in clean mode and adds coverage so fish/zsh profile env plus wrapper synthesis stay aligned.
Constraint: The wrapper must preserve Taskers shell integration even when shell-specific argv no longer flows through Ghostty
Rejected: Leave clean fish on --no-config only | it breaks Taskers lifecycle and metadata hooks for fish sessions
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Clean profile means no user config, not no Taskers integration; keep fish/zsh profile-sensitive wrapper behavior covered by tests
Tested: cargo test -p taskers-runtime --lib shell_wrapper
Tested: cargo test -p taskers-runtime --lib fish_and_zsh_launch_specs_preserve_shell_profile_env
Tested: cargo test -p taskers-ghostty --lib host_options
Tested: cargo test -p taskers runtime_bootstrap_tests --bin taskers-gtk
Tested: cargo install --path crates/taskers-app --force
Not-tested: Manual fish clean-profile launch from the desktop path1 parent 3a7d020 commit f2b5c3a
2 files changed
Lines changed: 5 additions & 1 deletion
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
779 | 779 | | |
780 | 780 | | |
781 | 781 | | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
782 | 786 | | |
783 | 787 | | |
784 | 788 | | |
| |||
0 commit comments