wip

Author: avvertix

src/parxy_core/services/contentmd_service.py

@@ -20,6 +20,20 @@ class ContentMdService:
     # Private helpers
     # ------------------------------------------------------------------
 
+    # Roles that provide structure or navigation rather than readable body text
+    _STRUCTURAL_ROLES: frozenset[str] = frozenset(
+        {
+            'heading',
+            'doc-title',
+            'doc-subtitle',
+            'doc-abstract',
+            'doc-toc',
+            'doc-pageheader',
+            'doc-pagefooter',
+            'caption',
+        }
+    )
+
     @staticmethod
     def _normalize(text: str) -> str:
         """Collapse any run of whitespace to a single space and strip."""
@@ -71,8 +85,10 @@ def _guess_title(document: Document) -> Optional[str]:
     def _infer_description(document: Document) -> Optional[str]:
         """Infer a description from document content.
 
-        Uses the ``doc-abstract`` block when present, otherwise the longest
-        :class:`TextBlock` across the first two pages.
+        Uses the ``doc-abstract`` block when present. Otherwise concatenates
+        the first five body :class:`TextBlock` objects (non-structural, across
+        the first two pages), normalises whitespace, and returns at most 200
+        characters.
         """
         from parxy_core.models.models import TextBlock
 
@@ -88,12 +104,16 @@ def _infer_description(document: Document) -> Optional[str]:
         if abstract:
             return ContentMdService._normalize(abstract.text)
 
-        text_blocks = [b for b in blocks if b.role != 'doc-title']
-        if not text_blocks:
+        body_blocks = [
+            b
+            for b in blocks
+            if (b.role or 'generic') not in ContentMdService._STRUCTURAL_ROLES
+        ]
+        if not body_blocks:
             return None
-        return ContentMdService._normalize(
-            max(text_blocks, key=lambda b: len(b.text)).text
-        )
+
+        combined = ' '.join(b.text for b in body_blocks[:5])
+        return ContentMdService._normalize(combined)[:200]
 
     @staticmethod
     def _build_frontmatter(

tests/services/test_contentmd_service.py

@@ -171,27 +171,45 @@ def test_description_from_doc_abstract_block(self):
         result = ContentMdService.render(doc)
         assert 'description: "Abstract content here."' in result
 
-    def test_description_from_longest_textblock_when_no_abstract(self):
-        blocks = [
-            make_text_block('Short.', role='paragraph'),
-            make_text_block(
-                'This is a considerably longer paragraph block.', role='paragraph'
-            ),
-        ]
+    def test_description_from_first_five_body_blocks(self):
+        blocks = [make_text_block(f'Sentence {i}.', role='paragraph') for i in range(7)]
         doc = make_doc(pages=[make_page(text='', blocks=blocks)])
         result = ContentMdService.render(doc)
-        assert 'description: "This is a considerably longer paragraph block."' in result
+        # Only the first five contribute; the sixth and seventh are ignored
+        assert 'Sentence 5' not in result.split('---\n')[1].split('\n')[0]
+        assert 'Sentence 0' in result
 
-    def test_description_excludes_doc_title_from_longest_candidate(self):
+    def test_description_excludes_structural_roles(self):
         blocks = [
-            make_text_block(
-                'This is a very long doc-title block text.', role='doc-title'
-            ),
-            make_text_block('Shorter paragraph.', role='paragraph'),
+            make_text_block('Table of contents text.', role='doc-toc'),
+            make_text_block('Page header text.', role='doc-pageheader'),
+            make_text_block('A heading block.', role='heading'),
+            make_text_block('Body content.', role='paragraph'),
         ]
         doc = make_doc(pages=[make_page(text='', blocks=blocks)])
         result = ContentMdService.render(doc)
-        assert 'description: "Shorter paragraph."' in result
+        assert 'description: "Body content."' in result
+
+    def test_description_truncated_to_200_chars(self):
+        long_text = 'word ' * 60  # well over 200 chars
+        blocks = [make_text_block(long_text, role='paragraph')]
+        doc = make_doc(pages=[make_page(text='', blocks=blocks)])
+        result = ContentMdService.render(doc)
+        fm_end = result.index('---\n', 4)
+        frontmatter = result[:fm_end]
+        desc_line = next(l for l in frontmatter.splitlines() if l.startswith('description:'))
+        # Strip the YAML quoting to measure the actual value length
+        value = desc_line[len('description: "'):-1]
+        assert len(value) <= 200
+
+    def test_description_contains_no_newlines(self):
+        blocks = [make_text_block('Line one.\nLine two.\nLine three.', role='paragraph')]
+        doc = make_doc(pages=[make_page(text='', blocks=blocks)])
+        result = ContentMdService.render(doc)
+        fm_end = result.index('---\n', 4)
+        frontmatter = result[:fm_end]
+        desc_line = next(l for l in frontmatter.splitlines() if l.startswith('description:'))
+        assert '\n' not in desc_line
 
     def test_description_searches_first_two_pages(self):
         page1 = make_page(number=1, text='', blocks=[make_text_block('Page 1 text.')])