more cleanup

Author: AR Abdul Azeez

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/debug/internal/logging/otel/android/OtelPlatformProvider.kt

@@ -120,22 +120,20 @@ internal class OtelPlatformProvider(
 
     override val minFileAgeForReadMillis: Long = 5_000
 
-    // Remote logging configuration
+    // Cached from SharedPreferences on first access and held for the session.
+    // Mid-session config updates are handled by OtelLifecycleManager reading
+    // from ConfigModel directly, not from these cached values.
     override val isRemoteLoggingEnabled: Boolean by lazy {
         idResolver.resolveRemoteLoggingEnabled()
     }
 
-    /**
-     * The minimum log level to send remotely as a string.
-     * - "logging_config": {"log_level": "ERROR"} → returns "ERROR" (enabled, on allowlist)
-     * - "logging_config": {} → returns null (disabled, not on allowlist)
-     * - No config cached yet → returns null (first launch)
-     */
+    // Cached from SharedPreferences on first access and held for the session.
+    // Mid-session config updates are handled by OtelLifecycleManager reading
+    // from ConfigModel directly, not from these cached values.
     @Suppress("TooGenericExceptionCaught", "SwallowedException")
     override val remoteLogLevel: String? by lazy {
         try {
-            val configLevel = idResolver.resolveRemoteLogLevel()
-            configLevel?.name
+            idResolver.resolveRemoteLogLevel()?.name
         } catch (e: Exception) {
             null
         }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OtelLifecycleManager.kt

@@ -41,6 +41,8 @@ internal class OtelLifecycleManager(
         createAndroidOtelPlatformProvider(context)
     }
 
+    private val logger = AndroidOtelLogger()
+
     private var crashHandler: IOtelCrashHandler? = null
     private var anrDetector: IOtelAnrDetector? = null
     private var remoteTelemetry: IOtelOpenTelemetryRemote? = null
@@ -59,7 +61,7 @@ internal class OtelLifecycleManager(
         }
 
         try {
-            val cachedConfig = readCurrentConfig()
+            val cachedConfig = readCurrentCachedConfig()
             val action = OtelConfigEvaluator.evaluate(old = null, new = cachedConfig)
             applyAction(action, cachedConfig)
         } catch (t: Throwable) {
@@ -105,7 +107,7 @@ internal class OtelLifecycleManager(
     // Internal
     // ------------------------------------------------------------------
 
-    private fun readCurrentConfig(): OtelConfig {
+    private fun readCurrentCachedConfig(): OtelConfig {
         val enabled = platformProvider.isRemoteLoggingEnabled
         val levelStr = platformProvider.remoteLogLevel
         val level = levelStr?.let {
@@ -195,7 +197,6 @@ internal class OtelLifecycleManager(
 
     private fun startCrashHandler() {
         if (crashHandler != null) return
-        val logger = AndroidOtelLogger()
         val handler = OneSignalCrashHandlerFactory.createCrashHandler(context, logger)
         handler.initialize()
         crashHandler = handler
@@ -204,7 +205,6 @@ internal class OtelLifecycleManager(
 
     private fun startAnrDetector() {
         if (anrDetector != null) return
-        val logger = AndroidOtelLogger()
         val detector = createAnrDetector(
             platformProvider,
             logger,