Injecting classes

Author: AR Abdul Azeez

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OtelLifecycleManager.kt

@@ -16,7 +16,9 @@ import com.onesignal.debug.internal.logging.otel.android.AndroidOtelLogger
 import com.onesignal.debug.internal.logging.otel.android.OtelPlatformProvider
 import com.onesignal.debug.internal.logging.otel.android.createAndroidOtelPlatformProvider
 import com.onesignal.otel.IOtelCrashHandler
+import com.onesignal.otel.IOtelLogger
 import com.onesignal.otel.IOtelOpenTelemetryRemote
+import com.onesignal.otel.IOtelPlatformProvider
 import com.onesignal.otel.OtelFactory
 import com.onesignal.otel.crash.IOtelAnrDetector
 
@@ -31,18 +33,31 @@ import com.onesignal.otel.crash.IOtelAnrDetector
  *
  * Thread safety: methods are synchronized on [lock] so that concurrent
  * calls from initEssentials (main) and the config store callback (IO) are safe.
+ *
+ * All factory parameters default to the real implementations, so production
+ * callers can use `OtelLifecycleManager(context)`. Tests can override any
+ * factory to inject mocks or throwing stubs.
  */
 @Suppress("TooManyFunctions")
 internal class OtelLifecycleManager(
     private val context: Context,
+    private val crashHandlerFactory: (Context, IOtelLogger) -> IOtelCrashHandler =
+        { ctx, log -> OneSignalCrashHandlerFactory.createCrashHandler(ctx, log) },
+    private val anrDetectorFactory: (IOtelPlatformProvider, IOtelLogger, Long, Long) -> IOtelAnrDetector =
+        { pp, log, threshold, interval -> createAnrDetector(pp, log, threshold, interval) },
+    private val remoteTelemetryFactory: (IOtelPlatformProvider) -> IOtelOpenTelemetryRemote =
+        { pp -> OtelFactory.createRemoteTelemetry(pp) },
+    private val platformProviderFactory: (Context) -> OtelPlatformProvider =
+        { ctx -> createAndroidOtelPlatformProvider(ctx) },
+    private val loggerFactory: () -> IOtelLogger = { AndroidOtelLogger() },
 ) : ISingletonModelStoreChangeHandler<ConfigModel> {
     private val lock = Any()
 
     private val platformProvider: OtelPlatformProvider by lazy {
-        createAndroidOtelPlatformProvider(context)
+        platformProviderFactory(context)
     }
 
-    private val logger = AndroidOtelLogger()
+    private val logger: IOtelLogger by lazy { loggerFactory() }
 
     private var crashHandler: IOtelCrashHandler? = null
     private var anrDetector: IOtelAnrDetector? = null
@@ -192,19 +207,19 @@ internal class OtelLifecycleManager(
 
     private fun startCrashHandler() {
         if (crashHandler != null) return
-        val handler = OneSignalCrashHandlerFactory.createCrashHandler(context, logger)
+        val handler = crashHandlerFactory(context, logger)
         handler.initialize()
         crashHandler = handler
         Logging.info("OneSignal: Crash handler initialized — logs at: ${platformProvider.crashStoragePath}")
     }
 
     private fun startAnrDetector() {
         if (anrDetector != null) return
-        val detector = createAnrDetector(
+        val detector = anrDetectorFactory(
             platformProvider,
             logger,
-            anrThresholdMs = AnrConstants.DEFAULT_ANR_THRESHOLD_MS,
-            checkIntervalMs = AnrConstants.DEFAULT_CHECK_INTERVAL_MS,
+            AnrConstants.DEFAULT_ANR_THRESHOLD_MS,
+            AnrConstants.DEFAULT_CHECK_INTERVAL_MS,
         )
         detector.start()
         anrDetector = detector
@@ -214,7 +229,7 @@ internal class OtelLifecycleManager(
     @Suppress("TooGenericExceptionCaught")
     private fun startOtelLogging(logLevel: LogLevel) {
         remoteTelemetry?.shutdown()
-        val telemetry = OtelFactory.createRemoteTelemetry(platformProvider)
+        val telemetry = remoteTelemetryFactory(platformProvider)
         remoteTelemetry = telemetry
         val shouldSend: (LogLevel) -> Boolean = { level ->
             logLevel != LogLevel.NONE && level <= logLevel

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/debug/internal/logging/otel/android/OtelPlatformProviderTest.kt

@@ -777,6 +777,104 @@ class OtelPlatformProviderTest : FunSpec({
         provider.osName shouldBe "Android"
     }
 
+    // ===== Fresh install / all-missing scenario =====
+
+    test("fresh install: all lazy properties return safe defaults without crashing") {
+        val provider = createAndroidOtelPlatformProvider(appContext!!)
+
+        provider.appId shouldContain "e1100000-0000-4000-a000-"
+        provider.onesignalId shouldBe null
+        provider.pushSubscriptionId shouldBe null
+        provider.isRemoteLoggingEnabled shouldBe false
+        provider.remoteLogLevel shouldBe null
+        provider.appIdForHeaders shouldNotBe null
+        provider.sdkBase shouldBe "android"
+        provider.osName shouldBe "Android"
+        provider.crashStoragePath shouldContain "onesignal"
+    }
+
+    test("lazy properties cache the initial value and ignore later SharedPreferences changes") {
+        val provider = createAndroidOtelPlatformProvider(appContext!!)
+
+        provider.isRemoteLoggingEnabled shouldBe false
+        provider.remoteLogLevel shouldBe null
+
+        val remoteLoggingParams = JSONObject().apply { put("logLevel", "ERROR") }
+        val configModel = JSONObject().apply {
+            put(ConfigModel::remoteLoggingParams.name, remoteLoggingParams)
+        }
+        val configArray = JSONArray().apply { put(configModel) }
+        sharedPreferences!!.edit()
+            .putString(PreferenceOneSignalKeys.MODEL_STORE_PREFIX + configNameSpace, configArray.toString())
+            .commit()
+
+        provider.isRemoteLoggingEnabled shouldBe false
+        provider.remoteLogLevel shouldBe null
+    }
+
+    test("getIsInForeground callback throws — appState returns unknown") {
+        val config = OtelPlatformProviderConfig(
+            crashStoragePath = "/test/path",
+            appPackageId = "com.test",
+            appVersion = "1.0",
+            context = appContext,
+            getIsInForeground = { throw RuntimeException("callback boom") }
+        )
+        val provider = OtelPlatformProvider(config)
+        provider.appState shouldBe "unknown"
+    }
+
+    test("getIsInForeground returns null — falls back to ActivityManager") {
+        val config = OtelPlatformProviderConfig(
+            crashStoragePath = "/test/path",
+            appPackageId = "com.test",
+            appVersion = "1.0",
+            context = appContext,
+            getIsInForeground = { null }
+        )
+        val provider = OtelPlatformProvider(config)
+        provider.appState shouldBeOneOf listOf("foreground", "background", "unknown")
+    }
+
+    test("null context and null callback — all provider properties return safe defaults") {
+        val config = OtelPlatformProviderConfig(
+            crashStoragePath = "/test/path",
+            appPackageId = "com.test",
+            appVersion = "1.0",
+            context = null,
+            getIsInForeground = null
+        )
+        val provider = OtelPlatformProvider(config)
+
+        provider.appState shouldBe "unknown"
+        provider.appPackageId shouldBe "com.test"
+        provider.appVersion shouldBe "1.0"
+        provider.crashStoragePath shouldBe "/test/path"
+        provider.isRemoteLoggingEnabled shouldBe false
+        provider.remoteLogLevel shouldBe null
+    }
+
+    test("corrupted SharedPreferences JSON — isRemoteLoggingEnabled returns false") {
+        sharedPreferences!!.edit()
+            .putString(PreferenceOneSignalKeys.MODEL_STORE_PREFIX + configNameSpace, "not valid json {{{")
+            .commit()
+
+        val provider = createAndroidOtelPlatformProvider(appContext!!)
+        provider.isRemoteLoggingEnabled shouldBe false
+        provider.remoteLogLevel shouldBe null
+    }
+
+    test("corrupted SharedPreferences JSON — appId returns error UUID") {
+        sharedPreferences!!.edit()
+            .putString(PreferenceOneSignalKeys.MODEL_STORE_PREFIX + configNameSpace, "not valid json {{{")
+            .commit()
+
+        val provider = createAndroidOtelPlatformProvider(appContext!!)
+        provider.appId shouldContain "e1100000-0000-4000-a000-"
+    }
+
+    // ===== Factory Function Tests =====
+
     test("createAndroidOtelPlatformProvider handles null appVersion gracefully") {
         // Given
         val mockContext = mockk<Context>(relaxed = true)