Commit 87d5ea4
Fix IAM display rendering issues on foldable Android devices
This commit addresses rendering issues with In-App Messages (IAM) on
foldable Android devices like Samsung Galaxy Fold/Flip.
Root cause:
- Foldable devices change screen size without triggering orientation changes
- The SDK only listened for CONFIG_ORIENTATION changes, missing fold/unfold events
- ViewUtils used deprecated APIs that don't properly handle multi-window scenarios
Changes:
1. ViewUtils.kt:
- Added API 30+ (Android 11+) implementation using WindowMetrics API
- getWindowHeight() now uses currentWindowMetrics for accurate dimensions
- getWindowWidth() and getFullbleedWindowWidth() updated similarly
- Properly handles foldable device screen size changes
2. ApplicationService.kt:
- Added screen size change detection via onConfigurationChanged
- Tracks screenWidthDp/screenHeightDp to detect fold/unfold events
- New onScreenSizeChanged() method triggers IAM view recreation
- Fires onActivityStopped/onActivityAvailable to recalculate IAM dimensions
3. WebViewManager.kt:
- Updated comment to clarify fold/unfold handling alongside rotation
The fix ensures IAMs are properly resized and repositioned when users
fold/unfold their devices, preventing cut-off content and mispositioned
messages.
Co-authored-by: abdul <abdul@onesignal.com>1 parent b164424 commit 87d5ea4
File tree
3 files changed
+76
-4
lines changed- OneSignalSDK/onesignal
- core/src/main/java/com/onesignal
- common
- core/internal/application/impl
- in-app-messages/src/main/java/com/onesignal/inAppMessages/internal/display/impl
3 files changed
+76
-4
lines changedLines changed: 34 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| 32 | + | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
35 | 49 | | |
36 | 50 | | |
37 | 51 | | |
| |||
87 | 101 | | |
88 | 102 | | |
89 | 103 | | |
90 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
91 | 108 | | |
92 | 109 | | |
93 | 110 | | |
| |||
96 | 113 | | |
97 | 114 | | |
98 | 115 | | |
99 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
100 | 131 | | |
101 | 132 | | |
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
| |||
93 | 96 | | |
94 | 97 | | |
95 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
96 | 120 | | |
97 | 121 | | |
98 | 122 | | |
| |||
368 | 392 | | |
369 | 393 | | |
370 | 394 | | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
371 | 412 | | |
372 | 413 | | |
373 | 414 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
266 | | - | |
| 266 | + | |
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
| |||
0 commit comments