Skip to content

Commit bbef266

Browse files
committed
fix: use versionName instead of versionCode for app version reporting
Aligns Android with iOS, which reports CFBundleShortVersionString (display version). Previously Android reported versionCode (integer build number), causing inconsistency for cross-platform frameworks like .NET MAUI. Falls back to versionCode if versionName is null. Made-with: Cursor
1 parent d39ed4e commit bbef266

File tree

1 file changed

+6
-8
lines changed
  • OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common

1 file changed

+6
-8
lines changed

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/AndroidUtils.kt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,12 @@ object AndroidUtils {
8080
}
8181

8282
fun getAppVersion(context: Context): String? {
83-
val appVersion: Int? =
84-
try {
85-
context.packageManager.getPackageInfo(context.packageName, 0).versionCode
86-
} catch (e: PackageManager.NameNotFoundException) {
87-
null
88-
}
89-
90-
return appVersion?.toString()
83+
return try {
84+
val packageInfo = context.packageManager.getPackageInfo(context.packageName, 0)
85+
packageInfo.versionName ?: packageInfo.versionCode.toString()
86+
} catch (e: PackageManager.NameNotFoundException) {
87+
null
88+
}
9189
}
9290

9391
fun getManifestMeta(

0 commit comments

Comments
 (0)