Skip to content

Commit e0c569c

Browse files
committed
fix ci builds
1 parent 55fe75b commit e0c569c

6 files changed

Lines changed: 42 additions & 152 deletions

File tree

examples/build.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ This document contains all the prompts and requirements needed to build the OneS
1212
Build a sample Android app with:
1313
- MVVM architecture with Jetpack Compose UI
1414
- Kotlin Coroutines for background threading (Dispatchers.IO, Dispatchers.Main)
15-
- Gradle Kotlin DSL with buildSrc for type-safe dependency management
15+
- Gradle Kotlin DSL with inline dependency versions (no buildSrc, so it works when included from the SDK project)
1616
- Support for Google FCM and Huawei HMS product flavors (matching existing OneSignalDemo setup)
1717
- Package name: com.onesignal.sdktest (must match google-services.json and agconnect-services.json)
1818
- All dialogs should have EMPTY input fields (for Appium testing - test framework enters values)
@@ -835,10 +835,6 @@ Implementation:
835835

836836
```
837837
examples/demo/
838-
├── buildSrc/
839-
│ └── src/main/kotlin/
840-
│ ├── Versions.kt # Version constants (includes Compose versions)
841-
│ └── Dependencies.kt # Dependency strings (includes Compose deps)
842838
├── app/
843839
│ ├── src/main/
844840
│ │ ├── java/com/onesignal/sdktest/

examples/demo/app/build.gradle.kts

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11
plugins {
2-
id(Plugins.androidApplication)
3-
id(Plugins.kotlinAndroid)
2+
id("com.android.application")
3+
id("kotlin-android")
44
}
55

66
// Apply GMS or Huawei plugin based on build variant
77
// Check at configuration time, not when task graph is ready
88
val taskRequests = gradle.startParameter.taskRequests.toString().lowercase()
99
if (taskRequests.contains("gms")) {
10-
apply(plugin = Plugins.googleServices)
10+
apply(plugin = "com.google.gms.google-services")
1111
} else if (taskRequests.contains("huawei")) {
12-
apply(plugin = Plugins.huaweiAgconnect)
12+
apply(plugin = "com.huawei.agconnect")
1313
}
1414

1515
// OneSignal SDK version - can be overridden via gradle property SDK_VERSION
16-
val sdkVersion: String = rootProject.findProperty("SDK_VERSION") as? String ?: Versions.oneSignalSdk
16+
val sdkVersion: String = rootProject.findProperty("SDK_VERSION") as? String ?: "5.6.1"
1717

1818
android {
19-
namespace = AppConfig.applicationId
20-
compileSdk = Versions.compileSdk
19+
namespace = "com.onesignal.sdktest"
20+
compileSdk = 34
2121

2222
defaultConfig {
23-
minSdk = Versions.minSdk
24-
targetSdk = Versions.targetSdk
25-
versionCode = Versions.versionCode
26-
versionName = Versions.versionName
23+
minSdk = 21
24+
targetSdk = 34
25+
versionCode = 1
26+
versionName = "1.0"
2727
multiDexEnabled = true
2828

2929
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
@@ -34,20 +34,20 @@ android {
3434
}
3535

3636
composeOptions {
37-
kotlinCompilerExtensionVersion = Versions.composeCompiler
37+
kotlinCompilerExtensionVersion = "1.5.14"
3838
}
3939

4040
flavorDimensions += "default"
4141

4242
productFlavors {
4343
create("gms") {
4444
dimension = "default"
45-
applicationId = AppConfig.applicationId
45+
applicationId = "com.onesignal.sdktest"
4646
}
4747
create("huawei") {
4848
dimension = "default"
49-
minSdk = Versions.minSdk
50-
applicationId = AppConfig.applicationId
49+
minSdk = 21
50+
applicationId = "com.onesignal.sdktest"
5151
}
5252
}
5353

@@ -90,36 +90,36 @@ android {
9090

9191
dependencies {
9292
// Kotlin
93-
implementation(Dependencies.kotlinStdlib)
94-
implementation(Dependencies.coroutinesAndroid)
93+
implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24")
94+
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3")
9595

9696
// AndroidX
97-
implementation(Dependencies.multidex)
98-
implementation(Dependencies.appcompat)
99-
implementation(Dependencies.coreKtx)
97+
implementation("androidx.multidex:multidex:2.0.1")
98+
implementation("androidx.appcompat:appcompat:1.5.1")
99+
implementation("androidx.core:core-ktx:1.9.0")
100100

101101
// Compose BOM
102-
implementation(platform(Dependencies.composeBom))
103-
implementation(Dependencies.composeUi)
104-
implementation(Dependencies.composeUiGraphics)
105-
implementation(Dependencies.composeUiToolingPreview)
106-
implementation(Dependencies.composeMaterial3)
107-
implementation(Dependencies.composeMaterialIcons)
108-
implementation(Dependencies.composeRuntime)
109-
implementation(Dependencies.composeRuntimeLivedata)
110-
debugImplementation(Dependencies.composeUiTooling)
102+
implementation(platform("androidx.compose:compose-bom:2024.02.00"))
103+
implementation("androidx.compose.ui:ui")
104+
implementation("androidx.compose.ui:ui-graphics")
105+
implementation("androidx.compose.ui:ui-tooling-preview")
106+
implementation("androidx.compose.material3:material3")
107+
implementation("androidx.compose.material:material-icons-extended")
108+
implementation("androidx.compose.runtime:runtime")
109+
implementation("androidx.compose.runtime:runtime-livedata")
110+
debugImplementation("androidx.compose.ui:ui-tooling")
111111

112112
// Activity & Lifecycle Compose
113-
implementation(Dependencies.activityCompose)
114-
implementation(Dependencies.lifecycleViewModelCompose)
115-
implementation(Dependencies.lifecycleRuntimeCompose)
113+
implementation("androidx.activity:activity-compose:1.8.2")
114+
implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.7.0")
115+
implementation("androidx.lifecycle:lifecycle-runtime-compose:2.7.0")
116116

117117
// Lifecycle
118-
implementation(Dependencies.lifecycleViewModelKtx)
119-
implementation(Dependencies.lifecycleRuntimeKtx)
118+
implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.7.0")
119+
implementation("androidx.lifecycle:lifecycle-runtime-ktx:2.7.0")
120120

121121
// Google Play Services
122-
implementation(Dependencies.playServicesLocation)
122+
implementation("com.google.android.gms:play-services-location:21.0.0")
123123

124124
// OneSignal - Google Play Builds
125125
"gmsImplementation"("com.onesignal:OneSignal:$sdkVersion")
@@ -131,6 +131,6 @@ dependencies {
131131
exclude(group = "com.google.android.gms", module = "play-services-location")
132132
exclude(group = "com.google.firebase", module = "firebase-messaging")
133133
}
134-
"huaweiImplementation"(Dependencies.huaweiPush)
135-
"huaweiImplementation"(Dependencies.huaweiLocation)
134+
"huaweiImplementation"("com.huawei.hms:push:6.3.0.304")
135+
"huaweiImplementation"("com.huawei.hms:location:4.0.0.300")
136136
}

examples/demo/build.gradle.kts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ buildscript {
99
maven { url = uri("https://developer.huawei.com/repo/") }
1010
}
1111
dependencies {
12-
classpath("com.android.tools.build:gradle:${Versions.androidGradlePlugin}")
13-
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:${Versions.kotlin}")
14-
classpath("com.google.gms:google-services:${Versions.googleServices}")
15-
classpath("com.huawei.agconnect:agcp:${Versions.huaweiAgcp}")
12+
classpath("com.android.tools.build:gradle:8.8.2")
13+
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.24")
14+
classpath("com.google.gms:google-services:4.3.10")
15+
classpath("com.huawei.agconnect:agcp:1.9.1.304")
1616
}
1717
}
1818

examples/demo/buildSrc/build.gradle.kts

Lines changed: 0 additions & 8 deletions
This file was deleted.

examples/demo/buildSrc/src/main/kotlin/Dependencies.kt

Lines changed: 0 additions & 52 deletions
This file was deleted.

examples/demo/buildSrc/src/main/kotlin/Versions.kt

Lines changed: 0 additions & 46 deletions
This file was deleted.

0 commit comments

Comments
 (0)