[Bug]: NullPointerException :com.onesignal.OneSignalRemoteParams$FCMParams on 4.8.6

[NweThazin]

What happened?

Getting crash in Firebase Crashlytics Console

    Fatal Exception: java.lang.NullPointerException: Attempt to read from field 'com.onesignal.OneSignalRemoteParams$FCMParams com.onesignal.OneSignalRemoteParams$Params.fcmParams' on a null object reference in method 'com.onesignal.PushRegistratorFCM com.onesignal.OneSignal.getPushRegistratorFCM()'
       at com.onesignal.OneSignal.getPushRegistratorFCM(OneSignal.java:1071)
       at com.onesignal.OneSignal.getPushRegistrator(OneSignal.java:1062)
       at com.onesignal.OneSignal.registerForPushToken(OneSignal.java:1080)
       at com.onesignal.OneSignal.access$1400(OneSignal.java:86)
       at com.onesignal.OneSignal$7.complete(OneSignal.java:1130)
       at com.onesignal.OneSignalRemoteParams.processJson(OneSignalRemoteParams.java:211)
       at com.onesignal.OneSignalRemoteParams.access$100(OneSignalRemoteParams.java:12)
       at com.onesignal.OneSignalRemoteParams$1.onSuccess(OneSignalRemoteParams.java:156)
       at com.onesignal.OneSignalRestClient$5.run(OneSignalRestClient.java:279)
       at java.lang.Thread.run(Thread.java:1012)

Steps to reproduce?

This crash occurred within first 1–2 seconds of user session, and users might not have noticed crash

What did you expect to happen?

I expect not to have this crash issue during initial app launch.

OneSignal Android SDK version

4.8.6

Android version

15

Specific Android models

Android 15, 14
according to firebase crashlytics report, crashes happened mostly on Samsung devices

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[jinliu9508]

Hi @NweThazin, thank you for reporting this! This issue appears to be fixed in the SDK User Model (v5.0+). For those experiencing the same issue, upgrading to the latest v5 version should resolve it. If you're unable to migrate to the User Model, upgrading to the latest version of the Player Model should reduce the frequency of the crash.

[NweThazin]

@jinliu9508 Thank you for your reply.
We will upgrade to the latest OneSignal SDK soon.
However, the problem is that we have been using version 4.8.6 for quite a long time.
The crash happened only in a specific version of our app.
After we create another build including same changes like a specific version of our app, the crash no longer occurred.
We didn’t include any changes related to OneSignal library in the problematic app version.
I would like to know what possible scenario could have caused this crash problem. Is it because couldn't get FCM parameter when connect to OneSignal?

[jkasten2]

@NweThazin based on the stack trace you shared the remote parameters were received correctly.

I reviewed the code and the only edge-case I can see is if you change the OneSignal app id while the SDK was still initializing.

We have a newer 4.x version than the 4.8.6 you are using, 4.8.12. While I don't believe there were any changes around this code it does address some issues might effect your app.

• I highly recommend updating to a 5.x version. 4.x is considered legacy, there are no planned new releases (only critical issues that cause major lose in functionally or security fixes will be made for 4.x versions).

[jkasten2]

We haven't received any other reports of this issue in 4.x versions. Since 4.x is considered legacy and this doesn't qualify as a critical wide spread issue closing this issue.

Please update to a 5.x version and if you are still seeing this issue please open a new issue.