[Bug]: 5.4.0 - UserManager.onFocus -Model.getStringProperty java.lang.NullPointerException - null cannot be cast to non-null type kotlin.String

[ningkanggithub]

What happened?

      Non-fatal Exception: java.lang.NullPointerException: null cannot be cast to non-null type kotlin.String
   at com.onesignal.common.modeling.Model.getStringProperty(Model.kt:487)
   at com.onesignal.common.modeling.Model.getStringProperty$default(Model.kt:484)
   at com.onesignal.user.internal.properties.PropertiesModel.getOnesignalId(PropertiesModel.kt:12)
   at com.onesignal.user.internal.operations.impl.listeners.PropertiesModelStoreListener.getUpdateOperation(PropertiesModelStoreListener.kt:47)
   at com.onesignal.user.internal.operations.impl.listeners.PropertiesModelStoreListener.getUpdateOperation(PropertiesModelStoreListener.kt:13)
   at com.onesignal.core.internal.operations.listeners.SingletonModelStoreListener.onModelUpdated(SingletonModelStoreListener.kt:54)
   at com.onesignal.common.modeling.SingletonModelStore$onModelUpdated$1.invoke(SingletonModelStore.kt:66)
   at com.onesignal.common.modeling.SingletonModelStore$onModelUpdated$1.invoke(SingletonModelStore.kt:66)
   at com.onesignal.common.events.EventProducer.fire(EventProducer.kt:50)
   at com.onesignal.common.modeling.SingletonModelStore.onModelUpdated(SingletonModelStore.kt:66)
   at com.onesignal.common.modeling.ModelStore$onChanged$1.invoke(ModelStore.kt:96)
   at com.onesignal.common.modeling.ModelStore$onChanged$1.invoke(ModelStore.kt:96)
   at com.onesignal.common.events.EventProducer.fire(EventProducer.kt:50)
   at com.onesignal.common.modeling.ModelStore.onChanged(ModelStore.kt:96)
   at com.onesignal.common.modeling.Model$notifyChanged$1.invoke(Model.kt:662)
   at com.onesignal.common.modeling.Model$notifyChanged$1.invoke(Model.kt:662)
   at com.onesignal.common.events.EventProducer.fire(EventProducer.kt:50)
   at com.onesignal.common.modeling.Model.notifyChanged(Model.kt:662)
   at com.onesignal.common.modeling.Model.setOptAnyProperty(Model.kt:456)
   at com.onesignal.common.modeling.Model.setOptStringProperty(Model.kt:359)
   at com.onesignal.common.modeling.Model.setOptStringProperty$default(Model.kt:354)
   at com.onesignal.user.internal.properties.PropertiesModel.setTimezone(PropertiesModel.kt:48)
   at com.onesignal.user.internal.UserManager.onFocus(UserManager.kt:271)
   at com.onesignal.core.internal.application.impl.ApplicationService$handleFocus$1.invoke(ApplicationService.kt:395)
   at com.onesignal.core.internal.application.impl.ApplicationService$handleFocus$1.invoke(ApplicationService.kt:395)
   at com.onesignal.common.events.EventProducer.fire(EventProducer.kt:50)
   at com.onesignal.core.internal.application.impl.ApplicationService.handleFocus(ApplicationService.kt:395)
   at com.onesignal.core.internal.application.impl.ApplicationService.onActivityStarted(ApplicationService.kt:163)
   at android.app.Application.dispatchActivityStarted(Application.java:423)
   at android.app.Activity.dispatchActivityStarted(Activity.java:1647)
   at android.app.Activity.onStart(Activity.java:2202)
   at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:344)
   at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java)
   at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1713)
   at android.app.Activity.performStart(Activity.java:9267)
   at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4470)
   at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:282)
   at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:262)
   at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:234)
   at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:110)
   at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:84)
   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2908)
   at android.os.Handler.dispatchMessage(Handler.java:107)
   at android.os.Looper.loopOnce(Looper.java:249)
   at android.os.Looper.loop(Looper.java:337)
   at android.app.ActivityThread.main(ActivityThread.java:9638)
   at java.lang.reflect.Method.invoke(Method.java)
   at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:615)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Steps to reproduce?

Reported from Firebase Crashlytics dashboard

What did you expect to happen?

No Crash

OneSignal Android SDK version

[5.0.0, 5.99.99]

Android version

15

Specific Android models

Model:Xiaomi 12T Pro

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[jkasten2]

@ningkanggithub thanks for reporting, can you add a few more details to help us narrow down this issue?

1. What percentage and occurrences of this crash are you seeing?
2. What percentage of the crashes are happening in the background vs the foreground?
3. Are you able to reproduce the issue yourself?

[ningkanggithub]

1. What percentage and occurrences of this crash are you seeing?

• At present, the proportion of incidents that can be observed is not low. In the specific scenarios of the push, it is approximately 30%.

2. What percentage of the crashes are happening in the background vs the foreground?

• Almost all of them are in the foreground

3. Are you able to reproduce the issue yourself?

• Cannot be reproduced

[jinliu9508]

@ningkanggithub Do you know the exact SDK version where this NPE comes from? Were you migrating from a player model version (v4)?

[gajicm93]

To me it just randomly happened on first app start after clearing app data in settings.

So try testing with after clearing data or fresh install

[jinliu9508]

This has been fixed in the beta release. Please give it a try and let us know if the issue persists.