Skip to content

Commit 2bda911

Browse files
committed
ci: fix iOS version parsing in release PR
1 parent 0ea2c7e commit 2bda911

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

.github/workflows/create-release-pr.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,12 @@ jobs:
9393
# Get versions from target branch (not the release branch)
9494
CURRENT_VERSION=$(git show origin/${{ inputs.target_branch }}:package.json | jq -r .version)
9595
ANDROID_VERSION=$(git show origin/${{ inputs.target_branch }}:android/gradle/libs.versions.toml | grep -E '^onesignal[[:space:]]*=[[:space:]]*"' | sed -E 's/.*"([0-9.]+)".*/\1/')
96-
IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:OneSignalCapacitorPlugin.podspec | grep "OneSignalXCFramework" | sed -E "s/.*'([0-9.]+)'.*/\1/")
96+
IOS_VERSION=$(git show origin/${{ inputs.target_branch }}:OneSignalCapacitorPlugin.podspec | sed -nE "s/.*onesignal_xcframework_version = ['\"]([^'\"]+)['\"].*/\1/p" | head -n 1)
97+
98+
if [ -z "$IOS_VERSION" ]; then
99+
echo "::error::Failed to read iOS SDK version from OneSignalCapacitorPlugin.podspec"
100+
exit 1
101+
fi
97102
98103
echo "capacitor_from=$CURRENT_VERSION" >> $GITHUB_OUTPUT
99104
echo "android_from=$ANDROID_VERSION" >> $GITHUB_OUTPUT
@@ -137,7 +142,11 @@ jobs:
137142
exit 1
138143
fi
139144
140-
sed -i '' "s/s\.dependency 'OneSignalXCFramework', '[^']*'/s.dependency 'OneSignalXCFramework', '$VERSION'/" OnesignalCapacitorPlugin.podspec
145+
sed -i '' -E "s/(onesignal_xcframework_version = ['\"])[^'\"]+(['\"])/\1${VERSION}\2/" OneSignalCapacitorPlugin.podspec
146+
if ! grep -q "onesignal_xcframework_version = '${VERSION}'" OneSignalCapacitorPlugin.podspec; then
147+
echo "::error::Failed to update iOS SDK version in OneSignalCapacitorPlugin.podspec to ${VERSION}"
148+
exit 1
149+
fi
141150
echo "✓ Updated OnesignalCapacitorPlugin.podspec with iOS SDK ${VERSION}"
142151
143152
# Only commit if there are changes

0 commit comments

Comments
 (0)