chore(demo): increase retry attempts with backoff

Author: fadi-george

bun.lock

@@ -82,10 +82,12 @@ class OneSignalApiService {
       ...extra,
     };
 
-    // Retry once on `invalid_player_ids` to absorb the brief race where the
+    const maxAttempts = 3;
+
+    // Retry on `invalid_player_ids` to absorb the brief race where the
     // subscription has been created locally but is not yet visible to the
     // /notifications endpoint.
-    for (let attempt = 0; attempt < 2; attempt++) {
+    for (let attempt = 1; attempt <= maxAttempts; attempt++) {
       try {
         const response = await CapacitorHttp.post({
           url: 'https://onesignal.com/api/v1/notifications',
@@ -101,11 +103,10 @@ class OneSignalApiService {
           return false;
         }
 
-        const data = response.data as { errors?: { invalid_player_ids?: unknown } } | undefined;
-        const invalidIds = data?.errors?.invalid_player_ids;
+        const invalidIds = response.data?.errors?.invalid_player_ids;
         if (Array.isArray(invalidIds) && invalidIds.length > 0) {
-          if (attempt === 0) {
-            await new Promise((resolve) => setTimeout(resolve, 3_000));
+          if (attempt < maxAttempts) {
+            await new Promise((resolve) => setTimeout(resolve, 3_000 * attempt));
             continue;
           }
           console.error(

examples/demo/src/services/OneSignalApiService.ts

@@ -90,26 +90,42 @@ export class AppComponent {
         return;
       }
 
-      const response = await CapacitorHttp.post({
-        url: 'https://onesignal.com/api/v1/notifications',
-        headers: {
-          Accept: 'application/vnd.onesignal.v1+json',
-          'Content-Type': 'application/json',
-        },
-        data: {
-          app_id: ONESIGNAL_APP_ID,
-          include_subscription_ids: [subscriptionId],
-          headings: { en: 'Simple Notification' },
-          contents: { en: 'This is a simple push notification' },
-        },
-      });
-
-      if (response.status < 200 || response.status >= 300) {
-        this.log(`Send failed (${response.status}): ${JSON.stringify(response.data)}`);
+      const body = {
+        app_id: ONESIGNAL_APP_ID,
+        include_subscription_ids: [subscriptionId],
+        headings: { en: 'Simple Notification' },
+        contents: { en: 'This is a simple push notification' },
+      };
+      const maxAttempts = 3;
+
+      for (let attempt = 1; attempt <= maxAttempts; attempt++) {
+        const response = await CapacitorHttp.post({
+          url: 'https://onesignal.com/api/v1/notifications',
+          headers: {
+            Accept: 'application/vnd.onesignal.v1+json',
+            'Content-Type': 'application/json',
+          },
+          data: body,
+        });
+
+        if (response.status < 200 || response.status >= 300) {
+          this.log(`Send failed (${response.status}): ${JSON.stringify(response.data)}`);
+          return;
+        }
+
+        const invalidIds = response.data?.errors?.invalid_player_ids;
+        if (Array.isArray(invalidIds) && invalidIds.length > 0) {
+          if (attempt < maxAttempts) {
+            await new Promise((resolve) => setTimeout(resolve, 3_000 * attempt));
+            continue;
+          }
+          this.log(`Send failed: invalid_player_ids ${JSON.stringify(invalidIds)}`);
+          return;
+        }
+
+        this.log(`Sent. response: ${JSON.stringify(response.data)}`);
         return;
       }
-
-      this.log(`Sent. response: ${JSON.stringify(response.data)}`);
     } catch (err) {
       this.log(`sendTestNotification error: ${String(err)}`);
     } finally {

examples/demo_cap7/src/app/app.component.ts

@@ -82,10 +82,12 @@ class OneSignalApiService {
       ...extra,
     };
 
-    // Retry once on `invalid_player_ids` to absorb the brief race where the
+    const maxAttempts = 3;
+
+    // Retry on `invalid_player_ids` to absorb the brief race where the
     // subscription has been created locally but is not yet visible to the
     // /notifications endpoint.
-    for (let attempt = 0; attempt < 2; attempt++) {
+    for (let attempt = 1; attempt <= maxAttempts; attempt++) {
       try {
         const response = await CapacitorHttp.post({
           url: 'https://onesignal.com/api/v1/notifications',
@@ -101,11 +103,10 @@ class OneSignalApiService {
           return false;
         }
 
-        const data = response.data as { errors?: { invalid_player_ids?: unknown } } | undefined;
-        const invalidIds = data?.errors?.invalid_player_ids;
+        const invalidIds = response.data?.errors?.invalid_player_ids;
         if (Array.isArray(invalidIds) && invalidIds.length > 0) {
-          if (attempt === 0) {
-            await new Promise((resolve) => setTimeout(resolve, 3_000));
+          if (attempt < maxAttempts) {
+            await new Promise((resolve) => setTimeout(resolve, 3_000 * attempt));
             continue;
           }
           console.error(

examples/demo_pods/src/services/OneSignalApiService.ts

@@ -60,7 +60,6 @@
     "@capacitor/docgen": "^0.2.2",
     "@types/bun": "latest",
     "@vitest/coverage-v8": "^4.1.2",
-    "happy-dom": "^20.9.0",
     "typescript": "^5.9.3",
     "vite-plus": "0.1.20"
   },

package.json

@@ -32,7 +32,7 @@ export default defineConfig({
   },
   test: {
     clearMocks: true,
-    environment: 'happy-dom',
+    environment: 'node',
     include: ['**/*.test.ts', '**/*.test.tsx'],
     coverage: {
       exclude: ['mocks/**', 'src/helpers.ts'],