Skip to content

Commit 66854e2

Browse files
fix: [SDK-4742] remove Capacitor activity lifecycle nudge (#27)
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 7c687e6 commit 66854e2

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

android/src/main/kotlin/com/onesignal/capacitor/OneSignalCapacitorPlugin.kt

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
package com.onesignal.capacitor
22

3-
import android.app.Application
43
import com.getcapacitor.JSObject
54
import com.getcapacitor.Plugin
65
import com.getcapacitor.PluginCall
76
import com.getcapacitor.PluginMethod
87
import com.getcapacitor.annotation.CapacitorPlugin
98
import com.onesignal.OneSignal
109
import com.onesignal.common.OneSignalWrapper
11-
import com.onesignal.core.internal.application.IApplicationService
1210
import com.onesignal.inAppMessages.IInAppMessageClickEvent
1311
import com.onesignal.inAppMessages.IInAppMessageClickListener
1412
import com.onesignal.inAppMessages.IInAppMessageDidDismissEvent
@@ -137,11 +135,6 @@ class OneSignalCapacitorPlugin : Plugin(),
137135
OneSignalWrapper.sdkVersion = "010005"
138136
OneSignal.initWithContext(context, appId)
139137

140-
// If the SDK was initialized from a non-Activity context (FCM/work
141-
// managers) before this call, its ALC missed MainActivity.onResume
142-
// and isInForeground stays false. Forward the missed events now.
143-
nudgeApplicationServiceForeground()
144-
145138
OneSignal.Notifications.addPermissionObserver(permissionObserver)
146139
OneSignal.Notifications.addForegroundLifecycleListener(this)
147140
OneSignal.Notifications.addClickListener(this)
@@ -153,17 +146,6 @@ class OneSignalCapacitorPlugin : Plugin(),
153146
call.resolve()
154147
}
155148

156-
/** Forward the missed activity-resume to the SDK so isInForeground is
157-
* correct on cold start. No-op if the SDK already saw the resume. */
158-
private fun nudgeApplicationServiceForeground() {
159-
val activity = activity ?: return
160-
val appSvc = runCatching { OneSignal.getServiceOrNull<IApplicationService>() }.getOrNull() ?: return
161-
if (appSvc.isInForeground && appSvc.current === activity) return
162-
val callbacks = appSvc as? Application.ActivityLifecycleCallbacks ?: return
163-
callbacks.onActivityStarted(activity)
164-
callbacks.onActivityResumed(activity)
165-
}
166-
167149
private fun buildClickEventJson(event: INotificationClickEvent): JSObject {
168150
val ret = JSObject()
169151
val clickResult = JSObject()

0 commit comments

Comments
 (0)