From d4d590eb5e894a8fcbf538a31f98648e061fbe1c Mon Sep 17 00:00:00 2001 From: Fadi George Date: Tue, 2 Jun 2026 19:25:53 -0700 Subject: [PATCH] fix: [SDK-4742] remove Capacitor lifecycle nudge Co-authored-by: Cursor --- .../capacitor/OneSignalCapacitorPlugin.kt | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/android/src/main/kotlin/com/onesignal/capacitor/OneSignalCapacitorPlugin.kt b/android/src/main/kotlin/com/onesignal/capacitor/OneSignalCapacitorPlugin.kt index 9d8ea8a..7ff0fd0 100644 --- a/android/src/main/kotlin/com/onesignal/capacitor/OneSignalCapacitorPlugin.kt +++ b/android/src/main/kotlin/com/onesignal/capacitor/OneSignalCapacitorPlugin.kt @@ -1,6 +1,5 @@ package com.onesignal.capacitor -import android.app.Application import com.getcapacitor.JSObject import com.getcapacitor.Plugin import com.getcapacitor.PluginCall @@ -8,7 +7,6 @@ import com.getcapacitor.PluginMethod import com.getcapacitor.annotation.CapacitorPlugin import com.onesignal.OneSignal import com.onesignal.common.OneSignalWrapper -import com.onesignal.core.internal.application.IApplicationService import com.onesignal.inAppMessages.IInAppMessageClickEvent import com.onesignal.inAppMessages.IInAppMessageClickListener import com.onesignal.inAppMessages.IInAppMessageDidDismissEvent @@ -137,11 +135,6 @@ class OneSignalCapacitorPlugin : Plugin(), OneSignalWrapper.sdkVersion = "010005" OneSignal.initWithContext(context, appId) - // If the SDK was initialized from a non-Activity context (FCM/work - // managers) before this call, its ALC missed MainActivity.onResume - // and isInForeground stays false. Forward the missed events now. - nudgeApplicationServiceForeground() - OneSignal.Notifications.addPermissionObserver(permissionObserver) OneSignal.Notifications.addForegroundLifecycleListener(this) OneSignal.Notifications.addClickListener(this) @@ -153,17 +146,6 @@ class OneSignalCapacitorPlugin : Plugin(), call.resolve() } - /** Forward the missed activity-resume to the SDK so isInForeground is - * correct on cold start. No-op if the SDK already saw the resume. */ - private fun nudgeApplicationServiceForeground() { - val activity = activity ?: return - val appSvc = runCatching { OneSignal.getServiceOrNull() }.getOrNull() ?: return - if (appSvc.isInForeground && appSvc.current === activity) return - val callbacks = appSvc as? Application.ActivityLifecycleCallbacks ?: return - callbacks.onActivityStarted(activity) - callbacks.onActivityResumed(activity) - } - private fun buildClickEventJson(event: INotificationClickEvent): JSObject { val ret = JSObject() val clickResult = JSObject()