Skip to content

fix: [SDK-4742] remove Capacitor activity lifecycle nudge #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 1 commit into from
Jun 3, 2026
Merged

fix: [SDK-4742] remove Capacitor activity lifecycle nudge #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions android/src/main/kotlin/com/onesignal/capacitor/OneSignalCapacitorPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
package com.onesignal.capacitor

import android.app.Application
import com.getcapacitor.JSObject
import com.getcapacitor.Plugin
import com.getcapacitor.PluginCall
import com.getcapacitor.PluginMethod
import com.getcapacitor.annotation.CapacitorPlugin
import com.onesignal.OneSignal
import com.onesignal.common.OneSignalWrapper
import com.onesignal.core.internal.application.IApplicationService
import com.onesignal.inAppMessages.IInAppMessageClickEvent
import com.onesignal.inAppMessages.IInAppMessageClickListener
import com.onesignal.inAppMessages.IInAppMessageDidDismissEvent
Expand Down Expand Up @@ -137,11 +135,6 @@ class OneSignalCapacitorPlugin : Plugin(),
OneSignalWrapper.sdkVersion = "010005"
OneSignal.initWithContext(context, appId)

// If the SDK was initialized from a non-Activity context (FCM/work
// managers) before this call, its ALC missed MainActivity.onResume
// and isInForeground stays false. Forward the missed events now.
nudgeApplicationServiceForeground()

OneSignal.Notifications.addPermissionObserver(permissionObserver)
OneSignal.Notifications.addForegroundLifecycleListener(this)
OneSignal.Notifications.addClickListener(this)
Expand All @@ -153,17 +146,6 @@ class OneSignalCapacitorPlugin : Plugin(),
call.resolve()
}

/** Forward the missed activity-resume to the SDK so isInForeground is
* correct on cold start. No-op if the SDK already saw the resume. */
private fun nudgeApplicationServiceForeground() {
val activity = activity ?: return
val appSvc = runCatching { OneSignal.getServiceOrNull<IApplicationService>() }.getOrNull() ?: return
if (appSvc.isInForeground && appSvc.current === activity) return
val callbacks = appSvc as? Application.ActivityLifecycleCallbacks ?: return
callbacks.onActivityStarted(activity)
callbacks.onActivityResumed(activity)
}

private fun buildClickEventJson(event: INotificationClickEvent): JSObject {
val ret = JSObject()
val clickResult = JSObject()
Expand Down
Loading